Skip to content

Conversation

@Gold856
Copy link
Collaborator

@Gold856 Gold856 commented Sep 12, 2025

Description

This allows Gradle to skip building the UI if none of the files in photon-client changed, which allows us to make the JAR task depend on the UI build task without wasting time rebuilding unnecessarily, which means building the UI no longer needs to be a separate step.

Fixes #2085.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@Gold856 Gold856 requested a review from a team as a code owner September 12, 2025 16:34
@github-actions github-actions bot added the backend Things relating to photon-core and photon-server label Sep 12, 2025
@Gold856
Copy link
Collaborator Author

Gold856 commented Sep 12, 2025

Needs testing. Also, since you don't to run the task separately anymore, should we remove https://docs.photonvision.org/en/v2025.3.2/docs/contributing/building-photon.html#build-and-copy-ui-to-java-source?

@github-actions github-actions bot added the documentation Anything relating to https://docs.photonvision.org label Sep 12, 2025
samfreund
samfreund previously approved these changes Sep 12, 2025
@github-actions github-actions bot removed the backend Things relating to photon-core and photon-server label Sep 12, 2025
@samfreund samfreund force-pushed the declare-client-inputs-and-outputs branch 2 times, most recently from eb47e5c to 588d016 Compare September 12, 2025 17:21
@samfreund samfreund force-pushed the declare-client-inputs-and-outputs branch from 588d016 to 1dc24e8 Compare September 12, 2025 17:23
@Gold856 Gold856 force-pushed the declare-client-inputs-and-outputs branch from 83c95e2 to 9d87394 Compare September 13, 2025 07:11
@samfreund
Copy link
Member

LGTM, lemme remove reqs for those checks and do another test. Then I'll merge it.

@samfreund samfreund enabled auto-merge (squash) September 16, 2025 04:02
@samfreund samfreund merged commit 04e9bff into PhotonVision:main Sep 16, 2025
40 checks passed
@Gold856 Gold856 deleted the declare-client-inputs-and-outputs branch October 14, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Anything relating to https://docs.photonvision.org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploy task doesn't depend on buildAndCopyUI

2 participants