Remove pitch camera configuration #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@realSaddy needs spotless run it looks like |
Contributor
Author
|
@mcm001 I've run the apply. The remaining workflow failure seems to be CI-side, unrelated to the PR. |
Contributor
|
Needs a branch update and final review. |
Contributor
Author
|
Branch updated. CI Build failure unrelated to this PR. |
shueja
approved these changes
Oct 17, 2022
mcm001
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the pitch camera configuration from the front end and the back end.
Additionally, this fixes a 'this' binding bug related to saving the camera config that was throwing a console error. Use arrow functions to keep 'this' binded.
Tested w/ local build.
