-
Notifications
You must be signed in to change notification settings - Fork 263
Ci update #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci update #518
Conversation
|
Closes #519 |
Does this fix the NPM issues? This is just updating the Github Actions to a new version. If there is a fix, I don't mind adding it in here too |
|
Ah whoops. Misread node for npm, need more sleep. There is another issue, let me grab a link to a failed CI to show. https://github.com/PhotonVision/photonvision/actions/runs/3293708288/jobs/5430467353 |
|
I'm trying to replicate the error but I haven't been able to reproduce it. I removed the node container though (since we already have the setup-node action) so maybe that helped to fix it? Either that or I'm cursed to never run into the issue. Going to test the jar to make sure it still works on my Pi4 then this should be good to go. |
If the error ever wants to re-appear (ugh)
9c2fc0f to
dda5eba
Compare
|
I'm 99% sure this Closes #519 |
Update action versions so that github actions stop complaining about Node and set/get-ouput commands.
The only one that causes warnings now isdownload-artifactbut that hasn't gotten updates for a while.download-artifactwas updated 2 hours ago so no more warnings.