Skip to content

Conversation

@averycblack
Copy link
Contributor

@averycblack averycblack commented Oct 21, 2022

Update action versions so that github actions stop complaining about Node and set/get-ouput commands. The only one that causes warnings now is download-artifact but that hasn't gotten updates for a while. download-artifact was updated 2 hours ago so no more warnings.

@mdurrani808
Copy link
Contributor

mdurrani808 commented Oct 21, 2022

Closes #519

@averycblack
Copy link
Contributor Author

averycblack commented Oct 21, 2022

Closes #519

Does this fix the NPM issues? This is just updating the Github Actions to a new version. If there is a fix, I don't mind adding it in here too

@mdurrani808
Copy link
Contributor

Ah whoops. Misread node for npm, need more sleep. There is another issue, let me grab a link to a failed CI to show.

https://github.com/PhotonVision/photonvision/actions/runs/3293708288/jobs/5430467353
failed under photon-build (the first one).

@averycblack
Copy link
Contributor Author

I'm trying to replicate the error but I haven't been able to reproduce it. I removed the node container though (since we already have the setup-node action) so maybe that helped to fix it? Either that or I'm cursed to never run into the issue.

Going to test the jar to make sure it still works on my Pi4 then this should be good to go.

@averycblack averycblack marked this pull request as ready for review October 21, 2022 05:28
@averycblack averycblack requested a review from a team as a code owner October 21, 2022 05:28
@gerth2
Copy link
Contributor

gerth2 commented Oct 21, 2022

I'm 99% sure this Closes #519

@mcm001 mcm001 merged commit d24a8d4 into PhotonVision:master Oct 22, 2022
@averycblack averycblack deleted the ci-update branch October 22, 2022 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants