Skip to content

Add Websocket Camera Streaming #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Oct 30, 2022
Merged

Add Websocket Camera Streaming #529

merged 27 commits into from
Oct 30, 2022

Conversation

@gerth2
Copy link
Contributor

@gerth2 gerth2 commented Oct 22, 2022

Add logic to serve webcam streams over websockets

@gerth2
Copy link
Contributor Author

gerth2 commented Oct 22, 2022

closes #528

@gerth2 gerth2 force-pushed the send_camera_streams_over_websockets branch from 5e4f373 to 34b9d21 Compare October 22, 2022 14:26
@gerth2
Copy link
Contributor Author

gerth2 commented Oct 24, 2022

Next-steps - reduce server side to only support one stream per client. This should reduce the complexity of the per-frame serve operation, and allow us to send a binary message with just the jpeg bytes.

On the client side, use something like this to encode the bytes to base64 and stuff them into the DOM as the new image to show

@gerth2 gerth2 marked this pull request as ready for review October 25, 2022 13:32
@gerth2 gerth2 requested a review from a team as a code owner October 25, 2022 13:32
@gerth2 gerth2 mentioned this pull request Oct 25, 2022
Closed
gerth2 added 24 commits October 29, 2022 06:40
@gerth2
WIP adding second websocket handling for cameras
adc6feb
@gerth2
just more WIP
d4f9a9d
@gerth2
even more wip. Most java-side framework completed, but not yet debugged
8aded76
@gerth2
IT LIVES. Still needs lots of cleanup. But we're transferring and dis…
ddedeb4 
…playing data!
@gerth2
moved down an architecture layer. Improved multiple-camera handling
3645161
@gerth2
Additional WIP to help improve smoothness and performance, though not…
856b249 
… yet tested
@gerth2
bugfixes galore
398f951
@gerth2
tweak compression
728ebea
@gerth2
spotless
81abe78
@gerth2
more tweaks for handling slow/intermittent streams
50b258d
@gerth2
wpilibformat maybe?
df4733f
@gerth2
clang-format maybe?
9b588d4
@gerth2
WIP - adding thinclient. I don't like it yet, it should be more auto-…
1465ec4 
…generated than it is.
@gerth2
thinclient formatting fixups
6f3ab73
@gerth2
Reduced amount of empty send data by limiting to only one stream per …
8be4df0 
…client (which is all we really need). Framerate is up slightly, overhead is down.
@gerth2
bugfixes, faster streaming, better mjpeg compression settings, thincl…
5439785 
…ient working
@gerth2
spotless and formatting
0f76615
@gerth2
cmon wpiformat....
a254b19
@gerth2
re-added mjpg streams
d2e93a5
@gerth2
added a loading GIF to imporve the feeling of responsiveness
1fa396d
@gerth2
formatting
d50b9c5
@gerth2
urlparams and built-in thinclient
65cebde
@gerth2
wpiformat
1bb8b06
@gerth2
prevent wpiformat complaints
7cde189
@gerth2 gerth2 force-pushed the send_camera_streams_over_websockets branch from c8cb3f6 to d61aea5 Compare October 29, 2022 11:41
@gerth2
Copy link
Contributor Author

gerth2 commented Oct 29, 2022

This should be ready to see the light of day, with notable follow-ups:

#548

#547

#546

#545

@gerth2 gerth2 mentioned this pull request Oct 30, 2022
Closed
@gerth2 gerth2 linked an issue Oct 30, 2022 that may be closed by this pull request
Camera stream sometimes doesn’t appear on page load #70
Closed
@gerth2 gerth2 merged commit aaac6a4 into PhotonVision:master Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcm001 mcm001 mcm001 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Camera stream sometimes doesn’t appear on page load

2 participants

@gerth2 @mcm001