Remove socket camera streaming #985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcm001
reviewed
Oct 26, 2023
| streamResultConsumers.clear(); | ||
|
|
||
| // Teardown and recreate streams | ||
| destroyStreams(); |
Contributor
There was a problem hiding this comment.
So does this mean we don't actually ever recreate the MJPGFrameConsumer now? That shouldn't cause issues (I guess the metadata about camera name in NT might be wrong unless we tell it to change? But AFAIK nobody uses that anyways)
Member
Author
There was a problem hiding this comment.
The camera name isn't used in the MJPGFrameConsumer constructor, so nothing should change afaik
Member
|
you can probably remove the UISettings file as well as it was added under similar goals |
mcm001
approved these changes
Oct 29, 2023
photon-core/src/main/java/org/photonvision/vision/processes/VisionModule.java
Outdated
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/vision/processes/VisionModule.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes websocket-based camera streaming functionality.
Fixes #975. This was caused by destroying the camera streams and recreating them on nickname change. Even when directly using
MJPGFrameConsumerand the streams were exactly the same, the freeze would occur when creating a newMjpegServerand require a refresh. I think this is simply how cscore works?