optimization of encodedBitmap_Bytes_withnumpy#99
Open
fookatchu wants to merge 1 commit intoPhotonsters:masterfrom
Open
optimization of encodedBitmap_Bytes_withnumpy#99fookatchu wants to merge 1 commit intoPhotonsters:masterfrom
fookatchu wants to merge 1 commit intoPhotonsters:masterfrom
Conversation
Collaborator
|
Nice job! I will integrate this in the next release.
thx, Nard
Op wo 24 apr. 2019 om 19:01 schreef fookatchu <notifications@github.com>:
… I recently wrote a library to read/write Photon files for my
SL1-to-Photon-Converter and largely used PhotonFile.py as a reference.
Unfortunately the code is not very compatible any more, so I thought I
would at least give something back, which is the optimized code for the rle
encoding. In my tests the new function is roughly 10 times faster than the
orignal numpy version. I did some tests and the resulting binarys are
identitical. If you need any further changes, please let me know and I will
try my best to implement them.
p.s.
This is my first pull request on github, so please excuse any mistakes.
------------------------------
You can view, comment on, or merge this pull request online at:
#99
Commit Summary
- optimization of encodedBitmap_Bytes_withnumpy
File Changes
- *M* PhotonFile.py
<https://github.com/Photonsters/PhotonFileEditor/pull/99/files#diff-0>
(26)
Patch Links:
- https://github.com/Photonsters/PhotonFileEditor/pull/99.patch
- https://github.com/Photonsters/PhotonFileEditor/pull/99.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#99>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/ACXNXGFKAZYPSCHZ32APGXLPSCHAHANCNFSM4HIGECRA>
.
|
Member
|
@NardJ you forgot this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently wrote a library to read/write Photon files for my SL1-to-Photon-Converter and largely used PhotonFile.py as a reference. Unfortunately the code is not very compatible any more, so I thought I would at least give something back, which is the optimized code for the rle encoding. In my tests the new function is roughly 10 times faster than the orignal numpy version. I did some tests and the resulting binarys are identitical. If you need any further changes, please let me know and I will try my best to implement them.
p.s.
This is my first pull request on github, so please excuse any mistakes.