-
-
Notifications
You must be signed in to change notification settings - Fork 52
WIP Feature/python webserver #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jamespilgrim
merged 82 commits into
PiTracLM:main
from
connorgallopo:feature/python-webserver
Sep 16, 2025
Merged
WIP Feature/python webserver #130
jamespilgrim
merged 82 commits into
PiTracLM:main
from
connorgallopo:feature/python-webserver
Sep 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I love this. I can't wait to see the final PR. |
0f301a5 to
ea054f7
Compare
jamespilgrim
approved these changes
Sep 16, 2025
Collaborator
jamespilgrim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saying that I reviewed this is kind of funny. I instead sort of stood to one side, looked in the direction of the code, and respectfully bowed to the great tower of work that this represents.
Fire when ready, Gridley.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a full rewrite of how we handle the webserver to display PiTrac shot metrics.
What does this PR do?
This PR deprecates the Tomee UI in favor of a lighter Python implementation. It still relies on the ActiveMQ backend, but should be much less resource intensive and easier to maintain!
Why is this change needed?
The current Tomee implementation of the ui is heavy, and is dependency heavy. We have seen lots of issues around how it checks for updates and the performance of running PiTrac. This is an implementation to start down the path of pulling out the Tomee code and moving to something lighter and more configurable.
Related Issue(s)
Closes #
Changes Made
Testing Performed
Test Environment
Test Results
pitrac test hardwarepassespitrac test camerapasses (if camera-related)pitrac test pulsepasses (if strobe-related)Test Commands Run
# Paste the actual commands and outputPerformance Impact
Breaking Changes
Dependencies
[ ] New dependencies added:
[ ] Updated dependencies:
Hardware Compatibility
Documentation
Screenshots/Videos
Checklist
Code Quality
Build & Test
./packaging/build.sh buildSubmission Requirements
git rebase -i HEAD~n)[PR TYPE] Brief descriptionAdditional Context