Skip to content

Account for nested map params (#277) #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Account for nested map params (#277) #280

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b9bc4f
Account for nested map params
agonzat Oct 27, 2025
71cf8e2
Fix code style
agonzat Oct 27, 2025
2436f3d
Revert cpp format changes
agonzat Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions generate_parameter_library_py/generate_parameter_library_py/parse_yaml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,9 @@ def int_to_integer_str(value: str):

def get_dynamic_parameter_field(yaml_parameter_name: str):
tmp = yaml_parameter_name.split('.')
parameter_field = tmp[-1]
return parameter_field
num_nested = [i for i, val in enumerate(tmp) if is_mapped_parameter(val)]
field = tmp[(max(num_nested) + 1) :] if len(num_nested) else tmp[-1]
return '.'.join(field)


def get_dynamic_mapped_parameter(yaml_parameter_name: str):
Expand All @@ -115,8 +116,8 @@ def get_dynamic_mapped_parameter(yaml_parameter_name: str):

def get_dynamic_struct_name(yaml_parameter_name: str):
tmp = yaml_parameter_name.split('.')
num_nested = sum([is_mapped_parameter(val) for val in tmp])
struct_name = tmp[: -(num_nested + 1)]
num_nested = [i for i, val in enumerate(tmp) if is_mapped_parameter(val)]
struct_name = tmp[: (min(num_nested))] if len(num_nested) else ''
return '.'.join(struct_name)


Expand Down Expand Up @@ -806,7 +807,7 @@ def parse_params(self, name, value, nested_name_list):
var = VariableDeclaration(code_gen_variable)

# check if runtime parameter
is_runtime_parameter = is_mapped_parameter(self.struct_tree.struct_name)
is_runtime_parameter = is_mapped_parameter(param_name)

if is_runtime_parameter:
declare_parameter_set = SetRuntimeParameter(param_name, code_gen_variable)
Expand Down
Loading