Skip to content

Remove white background from file lists#183

Merged
Pidgeot merged 2 commits intoPidgeot:masterfrom
TV4Fun:master
Sep 26, 2022
Merged

Remove white background from file lists#183
Pidgeot merged 2 commits intoPidgeot:masterfrom
TV4Fun:master

Conversation

@TV4Fun
Copy link
Copy Markdown
Contributor

@TV4Fun TV4Fun commented Sep 26, 2022

If your OS is set to use a dark profile, explicitly setting a white
background can make text unreadable. Instead, just leave it at the
default for non-selected files.

If your OS is set to use a dark profile, explicitly setting a white
background can make text unreadable. Instead, just leave it at the
default for non-selected files.
@TV4Fun TV4Fun marked this pull request as draft September 26, 2022 20:43
@TV4Fun
Copy link
Copy Markdown
Contributor Author

TV4Fun commented Sep 26, 2022

Just noticed that setting bg=None doesn't actually work if the item was previously selected (it stays green). Let me find a better fix.

Seting `bg=None` didn't work, but this does and looks very nice.
@TV4Fun TV4Fun marked this pull request as ready for review September 26, 2022 20:53
@TV4Fun
Copy link
Copy Markdown
Contributor Author

TV4Fun commented Sep 26, 2022

Pulling the fill color explicitly from Style() works the way it should.

@Pidgeot Pidgeot merged commit 20a58c3 into Pidgeot:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants