Implement E-07: Syntax Visibility in Blocks (Phase 2)#18
Merged
Conversation
- Add `phase: 1 | 2 | 3` required prop to BlockEditor; Phase 3 sets Blockly workspace to readOnly and hides the Run button - Update blockRegistry to accept showCode flag; when true, injects message1 = BlockDef.code into each Blockly block definition so the equivalent JS code appears as a second label inside the block body - Create CodeLabelTooltip: keyboard-accessible "?" button (Phase 2 only) that reveals an explanatory popover with aria-describedby wiring - Update DevBlockEditorScreen to read ?phase= query param and render a phase-switcher nav; marked as temporary pending E-11 integration - Add component + unit tests: phase-driven readOnly, showCode injection, code label sourced from BlockDef.code, tooltip open/close/keyboard/aria https://claude.ai/code/session_01K3ZDzQzrncMKnskQwpyWq8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phase: 1 | 2 | 3required prop to BlockEditor; Phase 3 setsBlockly workspace to readOnly and hides the Run button
message1 = BlockDef.code into each Blockly block definition so the
equivalent JS code appears as a second label inside the block body
that reveals an explanatory popover with aria-describedby wiring
a phase-switcher nav; marked as temporary pending E-11 integration
code label sourced from BlockDef.code, tooltip open/close/keyboard/aria
https://claude.ai/code/session_01K3ZDzQzrncMKnskQwpyWq8