Dropbox - new shared link components

[michelle0927]

Resolves #18364

Summary by CodeRabbit

• New Features

  • Added actions: Get Shared Link File, Get Shared Link Metadata, and List Shared Links.
  • Create/Update Share Link gains an optional Audience setting for non-basic accounts; audience choice set simplified.
  • Dropbox app adds Shared Link URL and password inputs, a paginated shared-link picker, and support for fetching shared-link files/metadata; share-link reuse improved.

• Chores

  • Multiple Dropbox action/source version bumps; package version moved to 1.1.0.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
pipedream-docs	Ignored			Sep 17, 2025 5:41pm
pipedream-docs-redirect-do-not-edit	Ignored			Sep 17, 2025 5:41pm

[coderabbitai]

Walkthrough

Adds shared-link functionality to the Dropbox component: new actions to list shared links, get shared link metadata, and fetch a file via a shared link; updates create/update share link to accept an audience for non-basic accounts; adds sharedLinkUrl and linkPassword propDefinitions and SDK wrapper methods; adjusts audience options and bumps multiple versions.

Changes

Cohort / File(s)	Summary
New shared-link actions components/dropbox/actions/list-shared-links/list-shared-links.mjs, components/dropbox/actions/get-shared-link-metadata/get-shared-link-metadata.mjs, components/dropbox/actions/get-shared-link-file/get-shared-link-file.mjs	Added actions: List Shared Links (paginated), Get Shared Link Metadata, and Get Shared Link File (downloads).
Create/Update Share Link components/dropbox/actions/create-update-share-link/create-update-share-link.mjs	Version bump; added dynamic audience prop for non-basic accounts and pass audience into createSharedLink settings.
Dropbox app: props & SDK wrappers components/dropbox/dropbox.app.mjs	Added sharedLinkUrl and linkPassword propDefinitions; added methods listSharedLinks, getSharedLinkMetadata, getSharedLinkFile; updated createSharedLink logic to reuse/update existing link for a path; sharedLinkUrl options support pagination.
Constants update components/dropbox/common/consts.mjs	CREATE_SHARED_LINK_AUDIENCE_OPTIONS reduced to ["public","team","no_one"] (removed "password", "members", "other").
Version bumps — actions & sources components/dropbox/actions/* (many files), components/dropbox/sources/all-updates/all-updates.mjs, components/dropbox/sources/new-file/new-file.mjs, components/dropbox/sources/new-folder/new-folder.mjs	Metadata version increments in many action/source modules; no functional changes.
Package version components/dropbox/package.json	Package version bumped from 1.0.1 to 1.1.0.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Action as Create/Update Share Link Action
  participant App as Dropbox App
  participant API as Dropbox API

  User->>Action: Provide path (+ audience if non-basic)
  Action->>App: createSharedLink(path, settings{audience?})
  App->>API: sharing/list_shared_links (path)
  API-->>App: existing links (links, cursor?)
  App->>App: find link with path_lower match
  alt Link exists
    App->>API: sharing/create_shared_link_with_settings (update or reuse)
    API-->>App: link
  else No link
    App->>API: sharing/create_shared_link_with_settings(settings)
    API-->>App: link
  end
  App-->>Action: link
  Action-->>User: Shared link URL

Loading

sequenceDiagram
  autonumber
  actor User
  participant List as List Shared Links Action
  participant Meta as Get Shared Link Metadata Action
  participant File as Get Shared Link File Action
  participant App as Dropbox App
  participant API as Dropbox API

  User->>List: Optional path
  List->>App: listSharedLinks(args)
  loop Paginate while has_more
    App->>API: sharing/list_shared_links(args or cursor)
    API-->>App: links, has_more, cursor
  end
  App-->>List: all links
  List-->>User: array of links

  User->>Meta: sharedLinkUrl (+ password?)
  Meta->>App: getSharedLinkMetadata({url, link_password})
  App->>API: sharing/get_shared_link_metadata
  API-->>App: metadata
  App-->>Meta: metadata
  Meta-->>User: metadata

  User->>File: sharedLinkUrl (+ password?)
  File->>App: getSharedLinkFile({url, link_password})
  App->>API: sharing/get_shared_link_file
  API-->>App: file content
  App-->>File: file content
  File-->>User: file content

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Suggested labels

User submitted

Suggested reviewers

• luancazarine
• GTFalcao
• andrewjschuang

Poem

Thump-thump I hop, links tucked in my paw,
I list and fetch, metadata I saw.
Audience set, old links I renew,
Bytes and paths gathered—carrots for you.
Version bumped, the rabbit's work is through. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description only contains "Resolves #18364" and does not follow the repository's required template (which requires a "## WHY" section); it lacks motivation, a summary of what changed, and verification/testing instructions.	Please update the PR description to follow the repository template by adding a "## WHY" explaining the motivation, a brief summary of the implemented changes (new actions, app methods, consts changes), and verification steps (create → list → metadata → download) plus any notes about breaking/behavioral changes.
Linked Issues Check	❓ Inconclusive	Against the objectives in [#18364], the PR implements list_shared_links, get_shared_link_metadata, and get_shared_link_file as new actions and adds corresponding app helper methods, and it updates create/update shared-link behavior to consider existing links and pass an audience setting; however it is unclear from the provided summary whether the create_shared_link flow fully supports all requested inputs (notably password and expiration) and whether the reduction of CREATE_SHARED_LINK_AUDIENCE_OPTIONS was intentional, so full compliance cannot be confirmed.	Confirm that the create-or-update shared-link action and the app's createSharedLink implementation accept and pass password and expiration to the Dropbox SDK, provide or point to tests that exercise the complete create → list → metadata → download flow, and verify the intentionality and impact of removing entries from CREATE_SHARED_LINK_AUDIENCE_OPTIONS.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "Dropbox - new shared link components" is concise, on-topic, and accurately reflects the primary changes in this PR (new shared-link actions and related Dropbox app updates), so a reviewer scanning history will understand the main intent.
Out of Scope Changes Check	✅ Passed	Most changes are in-scope for adding shared-link functionality (new actions, app methods, and related UI propDefinitions) and the remaining edits are metadata/version bumps; no unrelated functional changes were observed in the summary, though the modification of CREATE_SHARED_LINK_AUDIENCE_OPTIONS merits review to ensure it wasn't an unintended regression.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch issue-18364

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 671d725 and fb3965d.

📒 Files selected for processing (1)

• components/dropbox/actions/get-shared-link-file/get-shared-link-file.mjs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• components/dropbox/actions/get-shared-link-file/get-shared-link-file.mjs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: Publish TypeScript components
• GitHub Check: Verify TypeScript components
• GitHub Check: pnpm publish
• GitHub Check: Lint Code Base

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (3)

components/dropbox/actions/download-file-to-tmp/download-file-to-tmp.mjs (1)

54-55: Fix invalid regex in filename sanitizer (runtime syntax error).

Character class includes unescaped [], which prematurely closes the class and can throw. Use an allowlist or properly escape brackets.

Apply:

-      const cleanFileName = fileName.replace(/[?$#&{}[]<>\*!@:\+\\\/]/g, "");
+      // Remove characters unsafe for filenames across platforms
+      const cleanFileName = fileName.replace(/[^a-zA-Z0-9._ -]/g, "");
+      // If you prefer the denylist style:
+      // fileName.replace(/[?$#&{}\[\]<>*!@:+\\\/]/g, "")

components/dropbox/actions/search-files-folders/search-files-folders.mjs (1)

89-93: Fix inverted condition for include_highlights.

Currently sets options when value is undefined and omits when defined.

-      match_field_options: !isNil(includeHighlights)
-        ? undefined
-        : {
-          include_highlights: includeHighlights,
-        },
+      match_field_options: isNil(includeHighlights)
+        ? undefined
+        : {
+          include_highlights: includeHighlights,
+        },

components/dropbox/dropbox.app.mjs (1)

398-407: Bug: isEmpty() mis-handles booleans; remove_expiration can never be true.

isEmpty(true|false) returns true, forcing remove_expiration to false even when set to true.

Apply:

-            remove_expiration: isEmpty(args.remove_expiration)
-              ? false
-              : args.remove_expiration,
+            remove_expiration: isNil(args.remove_expiration)
+              ? false
+              : args.remove_expiration,

🧹 Nitpick comments (16)

components/dropbox/actions/upload-file/upload-file.mjs (3)

33-38: Fix copy: “folder” → “file” in Autorename description.

This action uploads a file.

Apply:

-      description: "If there's a conflict, have Dropbox try to autorename the folder to avoid the conflict.",
+      description: "If there's a conflict, have Dropbox try to autorename the file to avoid the conflict.",

---

65-75: Remove unused clientModified field (not exposed as a prop).

It’s always undefined; drop it to avoid confusion.

Apply:

-    const {
-      filePath,
-      path,
-      name,
-      autorename,
-      mute,
-      strictConflict,
-      mode,
-      clientModified,
-    } = this;
+    const {
+      filePath,
+      path,
+      name,
+      autorename,
+      mute,
+      strictConflict,
+      mode,
+    } = this;

-      client_modified: clientModified,

Also applies to: 90-90

---

94-94: Improve summary when path is empty.

Show a friendly fallback for root uploads.

Apply:

-    $.export("$summary", `File successfully uploaded to "${path?.label || path}"`);
+    $.export("$summary", `File successfully uploaded to "${path?.label || path || "root folder"}"`);

components/dropbox/actions/move-file-folder/move-file-folder.mjs (1)

58-71: Normalize destination path and avoid possible double slashes; minor naming tidy.

Use getNormalizedPath(..., true) and build to_path once.

Apply:

-    let normalizedPathTo = this.dropbox.getPath(pathTo);
+    const normalizedPathTo = this.dropbox.getNormalizedPath(pathTo, true);
     const normalizedPathFrom = this.dropbox.getPath(pathFrom);

-    // Add file/folder name to end of pathTo
-    const splited = normalizedPathFrom.split("/");
-    const fileName = splited[splited.length - 1];
-    normalizedPathTo += `/${fileName}`;
+    // Add file/folder name to end of pathTo
+    const parts = normalizedPathFrom.split("/");
+    const fileName = parts[parts.length - 1];
+    const toPath = `${normalizedPathTo}${fileName}`;

     const res = await this.dropbox.filesMove({
       from_path: normalizedPathFrom,
-      to_path: normalizedPathTo,
+      to_path: toPath,
       autorename,
       allow_ownership_transfer: allowOwnershipTransfer,
     });

Please test moving into root to confirm no leading “//”.

components/dropbox/actions/create-folder/create-folder.mjs (1)

41-46: Optional: guard against invalid folder names.

Consider rejecting names containing “/” to prevent unintended nested paths.

Would you like a small validation patch here?

components/dropbox/actions/upload-multiple-files/upload-multiple-files.mjs (1)

28-28: Fix grammar in filesPaths description.

Apply:

-      description: "Provide an array of either file URLs or paths to a files in the /tmp directory (for example, /tmp/myFile.pdf).",
+      description: "Provide an array of either file URLs or paths to files in the /tmp directory (for example, /tmp/myFile.pdf).",

components/dropbox/package.json (1)

1-27: Declare Node engine and prune redundant deps (stream, util)

• Add "engines": { "node": ">=16" } — got@^13 requires a modern Node runtime.
• Remove "stream" and "util" from components/dropbox/package.json — code imports Node core modules (e.g., components/dropbox/actions/download-file-to-tmp/download-file-to-tmp.mjs); confirm your build/tooling doesn't require npm polyfills before removing.

components/dropbox/actions/download-file-to-tmp/download-file-to-tmp.mjs (2)

43-43: Avoid logging the temporary download link.

Leaking signed URLs in logs is a security/privacy risk.

-      console.log("linkResponse: ", linkResponse);
+      // Consider: $.export("$debug", { hasLink: !!linkResponse?.result?.link });

---

59-62: Add timeouts to the download stream.

Network hangs will stall the action; set conservative timeouts/retries.

-      await pipeline(
-        got.stream(link),
-        fs.createWriteStream(tmpPath),
-      );
+      await pipeline(
+        got.stream(link, { timeout: { request: 15000 }, retry: { limit: 2 } }),
+        fs.createWriteStream(tmpPath),
+      );

components/dropbox/actions/rename-file-folder/rename-file-folder.mjs (1)

53-55: Nit: rename variable for clarity.

splitedPath → splitPath.

-    const splitedPath = normalizedPathFrom.split("/");
-    splitedPath[splitedPath.length - 1] = newName;
+    const splitPath = normalizedPathFrom.split("/");
+    splitPath[splitPath.length - 1] = newName;
     const res = await this.dropbox.filesMove({
       from_path: normalizedPathFrom,
-      to_path: splitedPath.join("/"),
+      to_path: splitPath.join("/"),

components/dropbox/actions/create-update-share-link/create-update-share-link.mjs (2)

110-119: Avoid sending undefined fields in settings.

Passing undefined keys can cause brittle request bodies. Build settings conditionally.

Apply:

-    const res = await this.dropbox.createSharedLink({
-      path: this.dropbox.getPath(path),
-      settings: {
-        require_password: requirePassword,
-        link_password: linkPassword,
-        expires,
-        access,
-        allow_download: allowDownload,
-        audience,
-      },
-    });
+    const settings = {
+      ...(requirePassword !== undefined && { require_password: requirePassword }),
+      ...(linkPassword && { link_password: linkPassword }),
+      ...(expires && { expires }),
+      ...(access && { access }),
+      ...(allowDownload !== undefined && { allow_download: allowDownload }),
+      ...(audience && { audience }),
+    };
+    const res = await this.dropbox.createSharedLink({
+      path: this.dropbox.getPath(path),
+      settings,
+    });

---

106-108: Validate timestamp format, not just chronology.

Date.parse returns NaN for invalid strings; the current check lets invalid values through.

Apply:

-    if (expires && Date.parse(expires) < Date.now()) {
+    if (expires) {
+      const t = Date.parse(expires);
+      if (Number.isNaN(t)) throw new Error("Invalid expires timestamp. Use ISO 8601, e.g. 2024-07-18T20:00:00Z");
+      if (t < Date.now()) throw new Error("Expire date must be later than the current datetime");
+    }

components/dropbox/dropbox.app.mjs (2)

99-124: Pagination for sharedLinkUrl options: honor has_more and guard empty links.

Without checking has_more, UI may keep requesting pages. Also guard against falsy links.

Apply:

-      async options({ prevContext }) {
+      async options({ prevContext }) {
         const {
-          result: {
-            links, cursor,
-          },
+          result: {
+            links = [], cursor, has_more,
+          },
         } = await this.listSharedLinks({
           cursor: prevContext?.cursor,
         });
-        const options = links?.map(({
+        const options = links.map(({
           url: value, name: label,
         }) => ({
           value,
           label: `${label} - ${value}`,
         })) || [];
         return {
           options,
           context: {
-            cursor,
+            cursor: has_more ? cursor : null,
           },
         };
       },

---

392-413: Optional: request direct-only links to avoid unrelated matches.

Filtering with direct_only reduces noise if multiple links exist under the same path subtree.

Apply:

-        const links = await dpx.sharingListSharedLinks({
-          path: args.path,
-        });
+        const links = await dpx.sharingListSharedLinks({
+          path: args.path,
+          direct_only: true,
+        });

components/dropbox/actions/list-shared-links/list-shared-links.mjs (2)

31-33: Avoid passing undefined path in args.

Only include path when provided to keep request bodies clean.

Apply:

-    const args = {
-      path: this.path?.value || this.path,
-    };
+    const args = {};
+    if (this.path) args.path = this.path?.value || this.path;

---

34-43: Guard against falsy links when spreading.

Spreading undefined throws; be defensive.

Apply:

-      sharedLinks.push(...links);
+      sharedLinks.push(...(links || []));

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9bdc89b and 671d725.

📒 Files selected for processing (23)

• components/dropbox/actions/create-a-text-file/create-a-text-file.mjs (1 hunks)
• components/dropbox/actions/create-folder/create-folder.mjs (1 hunks)
• components/dropbox/actions/create-or-append-to-a-text-file/create-or-append-to-a-text-file.mjs (1 hunks)
• components/dropbox/actions/create-update-share-link/create-update-share-link.mjs (4 hunks)
• components/dropbox/actions/delete-file-folder/delete-file-folder.mjs (1 hunks)
• components/dropbox/actions/download-file-to-tmp/download-file-to-tmp.mjs (1 hunks)
• components/dropbox/actions/get-shared-link-file/get-shared-link-file.mjs (1 hunks)
• components/dropbox/actions/get-shared-link-metadata/get-shared-link-metadata.mjs (1 hunks)
• components/dropbox/actions/list-file-folders-in-a-folder/list-file-folders-in-a-folder.mjs (1 hunks)
• components/dropbox/actions/list-file-revisions/list-file-revisions.mjs (1 hunks)
• components/dropbox/actions/list-shared-links/list-shared-links.mjs (1 hunks)
• components/dropbox/actions/move-file-folder/move-file-folder.mjs (1 hunks)
• components/dropbox/actions/rename-file-folder/rename-file-folder.mjs (1 hunks)
• components/dropbox/actions/restore-a-file/restore-a-file.mjs (1 hunks)
• components/dropbox/actions/search-files-folders/search-files-folders.mjs (1 hunks)
• components/dropbox/actions/upload-file/upload-file.mjs (1 hunks)
• components/dropbox/actions/upload-multiple-files/upload-multiple-files.mjs (1 hunks)
• components/dropbox/common/consts.mjs (0 hunks)
• components/dropbox/dropbox.app.mjs (3 hunks)
• components/dropbox/package.json (1 hunks)
• components/dropbox/sources/all-updates/all-updates.mjs (1 hunks)
• components/dropbox/sources/new-file/new-file.mjs (1 hunks)
• components/dropbox/sources/new-folder/new-folder.mjs (1 hunks)

💤 Files with no reviewable changes (1)

• components/dropbox/common/consts.mjs

🧰 Additional context used

🧬 Code graph analysis (3)

components/dropbox/actions/list-shared-links/list-shared-links.mjs (1)

components/dropbox/dropbox.app.mjs (6)

• args (346-351)
• args (480-488)
• links (395-397)
• cursor (288-297)
• cursor (344-344)
• cursor (478-478)

components/dropbox/dropbox.app.mjs (2)

components/dropbox/actions/list-shared-links/list-shared-links.mjs (2)

• args (30-32)
• args (35-39)

components/dropbox/actions/create-update-share-link/create-update-share-link.mjs (1)

• dpx (82-82)

components/dropbox/actions/get-shared-link-file/get-shared-link-file.mjs (1)

components/dropbox/actions/upload-multiple-files/upload-multiple-files.mjs (1)

• dropbox (99-110)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Lint Code Base
• GitHub Check: Publish TypeScript components
• GitHub Check: Verify TypeScript components

🔇 Additional comments (20)

components/dropbox/package.json (1)

3-3: Version bump LGTM.

Minor release aligns with new shared link features.

components/dropbox/actions/restore-a-file/restore-a-file.mjs (1)

7-7: Version bump LGTM.

components/dropbox/sources/new-folder/new-folder.mjs (1)

10-10: Version bump LGTM.

components/dropbox/actions/upload-file/upload-file.mjs (1)

9-9: Version bump LGTM.

components/dropbox/actions/move-file-folder/move-file-folder.mjs (1)

7-7: Version bump LGTM.

components/dropbox/actions/create-folder/create-folder.mjs (1)

7-7: Version bump LGTM.

components/dropbox/sources/new-file/new-file.mjs (1)

10-10: Version bump LGTM.

components/dropbox/actions/upload-multiple-files/upload-multiple-files.mjs (1)

11-11: Version bump LGTM.

components/dropbox/actions/download-file-to-tmp/download-file-to-tmp.mjs (1)

12-12: Version bump LGTM.

components/dropbox/actions/search-files-folders/search-files-folders.mjs (1)

9-9: Version bump LGTM.

components/dropbox/actions/list-file-revisions/list-file-revisions.mjs (1)

8-8: Version bump LGTM.

components/dropbox/actions/create-a-text-file/create-a-text-file.mjs (1)

7-7: Version bump LGTM.

components/dropbox/actions/create-or-append-to-a-text-file/create-or-append-to-a-text-file.mjs (1)

7-7: Version bump LGTM.

components/dropbox/actions/rename-file-folder/rename-file-folder.mjs (1)

7-7: Version bump LGTM.

components/dropbox/actions/delete-file-folder/delete-file-folder.mjs (1)

7-7: Version bump LGTM.

components/dropbox/sources/all-updates/all-updates.mjs (1)

10-10: Version bump LGTM — verification passed.

New shared-link actions present (components/dropbox/actions/list-shared-links/, get-shared-link-metadata/, get-shared-link-file/); app methods/props added (listSharedLinks, getSharedLinkMetadata, getSharedLinkFile, sharedLinkUrl, linkPassword); CREATE_SHARED_LINK_AUDIENCE_OPTIONS present and plumbed through create-update-share-link; components/dropbox/package.json version = 1.1.0.

components/dropbox/actions/list-file-folders-in-a-folder/list-file-folders-in-a-folder.mjs (1)

7-7: Version bump only — LGTM.

No functional changes. Safe to merge.

components/dropbox/dropbox.app.mjs (1)

418-441: New wrappers look good.

Thin pass-throughs with centralized error normalization keep the surface consistent.

components/dropbox/actions/get-shared-link-metadata/get-shared-link-metadata.mjs (1)

25-31: LGTM — correct arg names and summary.

Consistent with Dropbox API; pairs with sharedLinkUrl/linkPassword props.

components/dropbox/actions/create-update-share-link/create-update-share-link.mjs (1)

69-75: Audience prop: verified — values match Dropbox LinkAudience.
consts.CREATE_SHARED_LINK_AUDIENCE_OPTIONS (components/dropbox/common/consts.mjs) contains "public", "team", "no_one"; no changes required.