Azure Dev Ops - improve error handling

[michelle0927]

Resolves #15414

Summary by CodeRabbit

• New Features
  • Clearer authentication error messages for Azure DevOps, including guidance when a Personal Access Token is required.
• Bug Fixes
  • Improved reliability of Azure DevOps requests with better error handling.
• Chores
  • Bumped Azure DevOps package version to 0.1.1.
  • Updated New Event (Instant) source version to 0.0.4.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
pipedream-docs	Ignored			Sep 19, 2025 7:02pm
pipedream-docs-redirect-do-not-edit	Ignored			Sep 19, 2025 7:02pm

[coderabbitai]

Walkthrough

The Azure DevOps app’s internal request method was made asynchronous with added try/catch error handling, including a specific 401 case when not using OAuth. The source and package versions were incremented: app package to 0.1.1 and New Event (Instant) source to 0.0.4.

Changes

Cohort / File(s)	Summary
Azure DevOps app request flow components/azure_devops/azure_devops.app.mjs	_makeRequest converted to async, awaiting axios; wrapped in try/catch; added conditional handling for 401 to throw ConfigurationError when not using OAuth; otherwise rethrow error.
Version bumps components/azure_devops/package.json, components/azure_devops/sources/new-event/new-event.mjs	Bumped package version 0.1.0 → 0.1.1; bumped source version 0.0.3 → 0.0.4.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Client
  participant AzureDevOpsApp as AzureDevOps App
  participant Axios as HTTP Client

  Client->>AzureDevOpsApp: _makeRequest(args)
  activate AzureDevOpsApp
  AzureDevOpsApp->>Axios: await axios(request)
  alt Success
    Axios-->>AzureDevOpsApp: Response
    AzureDevOpsApp-->>Client: Response data
  else Error
    Axios-->>AzureDevOpsApp: Error (e)
    alt e.response.status == 401 AND auth != OAuth
      AzureDevOpsApp-->>Client: throw ConfigurationError("Valid Personal Access Token required")
    else Other errors
      AzureDevOpsApp-->>Client: rethrow e
    end
  end
  deactivate AzureDevOpsApp

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

I hop through code with whiskers bright,
Async winds turn day from night;
A 401? I twitch, I know—
Toss a clear error, then I go.
Versions nudge, releases sing,
Pipelines mend with a happy spring. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Linked Issues Check	⚠️ Warning	Linked issue #15414 reports that the "Cannot Assign" event type dropdown returns empty options; the changes in this PR are limited to making _makeRequest async and adding 401 error handling in components/azure_devops/azure_devops.app.mjs plus version bumps, and there is no visible modification to the code that populates trigger parameter options (e.g., the parameter resolution or the source that lists event types). Based on the provided diffs and summaries, the PR does not clearly implement the specific fix described in the linked issue.	Confirm and include the specific changes that fix the event-type parameter population (or explain how the new error handling directly resolves the reported symptom), and add notes or tests showing the dropdown now returns valid options for the "Cannot Assign" trigger before marking the linked issue as resolved.
Description Check	⚠️ Warning	The PR description contains only "Resolves #15414" and does not follow the repository's required template (the template requires a "## WHY" section), so it lacks the motivation, summary of code changes, and testing/impact details needed for a reviewer to assess the change.	Please update the PR description to follow the repository template by adding a "## WHY" section that explains the motivation, a brief summary of the code changes (files modified and rationale), how this resolves #15414, and any testing or manual verification steps so reviewers can validate the fix.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "Azure Dev Ops - improve error handling" is concise, directly related to the primary change in this PR (improvements to error handling in the Azure DevOps app module, notably components/azure_devops/azure_devops.app.mjs), and clear enough for a teammate scanning history to understand the main intent.
Out of Scope Changes Check	✅ Passed	The modified files are limited to the Azure DevOps app module and version bumps (components/azure_devops/azure_devops.app.mjs, package.json, and the source version), which are consistent with the stated objective of improving Azure DevOps error handling and preparing a release; there are no unrelated file changes in the provided summary.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch issue-15414

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (5)

components/azure_devops/azure_devops.app.mjs (5)

71-78: Also handle OAuth 401 (and 403) with actionable messages.

Give distinct guidance when OAuth token expired and when permissions are insufficient.

Apply this diff:

       try {
-        return await axios($, config);
+        return await axios($, config);
       } catch (error) {
-        if (error.response?.status === 401 && !useOAuth) {
-          throw new ConfigurationError("Azure DevOps Personal Access Token is required for this operation. Please verify that your personal access token is correct.");
-        }
-        throw error;
+        const status = error.response?.status;
+        if (status === 401) {
+          if (useOAuth) {
+            throw new ConfigurationError("Azure DevOps OAuth token is invalid or expired. Please reconnect your Azure DevOps account.");
+          }
+          throw new ConfigurationError("Azure DevOps Personal Access Token is invalid or missing. Verify your PAT in the connection.");
+        }
+        if (status === 403) {
+          throw new ConfigurationError("Access denied by Azure DevOps. Ensure the token has permissions to manage Service Hooks in this organization.");
+        }
+        throw error;
       }

---

63-71: Avoid manual query string concatenation; use URL to set api-version once.

Prevents duplicate api-version and handles existing params safely.

Apply this diff:

-      const config = {
+      const config = {
         url: url || `${this._baseUrl()}${path}`,
         headers: this._headers(useOAuth),
         ...otherArgs,
       };
-      config.url += config.url.includes("?")
-        ? "&"
-        : "?";
-      config.url += `api-version=${API_VERSION}`;
+      const u = new URL(config.url);
+      if (!u.searchParams.has("api-version")) {
+        u.searchParams.set("api-version", API_VERSION);
+      }
+      config.url = u.toString();

---

54-66: Consider a request timeout.

Guard external calls to avoid hanging on network issues (e.g., 10s).

Apply this diff:

       const config = {
         url: url || `${this._baseUrl()}${path}`,
         headers: this._headers(useOAuth),
+        timeout: 10_000,
         ...otherArgs,
       };

---

4-4: Update API version to 7.1.

The Service Hooks Event Types APIs and docs reference 7.1; upgrading improves compatibility while keeping response shape (id/name/value) stable. Validate Accounts list with 7.x as well. (learn.microsoft.com)

Apply this diff and smoke test the dropdown:

-const API_VERSION = "5.0";
+const API_VERSION = "7.1";

---

23-26: Return label/value objects for Event Type options.

Improves UX and avoids blank entries if UI expects objects. The API returns id and name for each event type. (learn.microsoft.com)

Apply this diff:

-        const types = await this.listEventTypes(organization);
-        return types?.map((type) => type.id);
+        const types = await this.listEventTypes(organization);
+        return types?.map((type) => ({
+          label: type.name || type.id,
+          value: type.id,
+        }));

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a6b99c9 and 53df08d.

📒 Files selected for processing (3)

• components/azure_devops/azure_devops.app.mjs (2 hunks)
• components/azure_devops/package.json (1 hunks)
• components/azure_devops/sources/new-event/new-event.mjs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: Lint Code Base
• GitHub Check: pnpm publish
• GitHub Check: Publish TypeScript components
• GitHub Check: Ensure component commits modify component versions
• GitHub Check: Verify TypeScript components

🔇 Additional comments (4)

components/azure_devops/package.json (1)

3-3: Version bump looks good.

No concerns on publishing 0.1.1.

Before merge, confirm the package gets published after this PR lands.

components/azure_devops/sources/new-event/new-event.mjs (1)

5-5: Source version bump is fine.

No functional changes here.

Please validate in the UI that the Event Type dropdown now renders options for an org with an invalid PAT (expect a clear config error vs. empty options).

components/azure_devops/azure_devops.app.mjs (2)

71-78: Good: user-friendly 401 handling for PAT.

Catches a common misconfig and surfaces a clear ConfigurationError.

---

88-94: Confirm this fixes Issue #15414 (empty Event Type options)

listEventTypes returns response.value and options map to type.id — verify by capturing the raw payload to ensure each item includes id (and name).

Location: components/azure_devops/azure_devops.app.mjs — options ~lines 22–26; listEventTypes ~lines 88–94.

• Local curl (with PAT): export ORG=...; export AZURE_DEVOPS_PAT=...; curl -sS -u :$AZURE_DEVOPS_PAT "https://dev.azure.com/$ORG/_apis/hooks/publishers/tfs/eventtypes?api-version=7.1-preview.1" | jq .
• Or add temporary debug in listEventTypes: const { value } = await this._makeRequest({...}); console.log('listEventTypes raw payload:', value); return value;