Hubspot - bug fix to list-forms action

[michelle0927]

Resolves #18392

Summary by CodeRabbit

• Bug Fixes

  • Improved reliability of the HubSpot “List Forms” action, ensuring results are aggregated correctly across pages without unintended mutations.
  • Corrected the reported form count for more accurate summaries.

• Chores

  • Bumped HubSpot “List Forms” action version to 0.0.8.
  • Updated HubSpot package version to 1.7.6.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
pipedream-docs	Ignored			Sep 17, 2025 6:27pm
pipedream-docs-redirect-do-not-edit	Ignored			Sep 17, 2025 6:27pm

[coderabbitai]

Walkthrough

The HubSpot list-forms action now uses a local accumulator to collect paginated results and returns that array, updating its version to 0.0.8. The package version for the HubSpot component is bumped to 1.7.6.

Changes

Cohort / File(s)	Summary
HubSpot Forms Action Logic `components/hubspot/actions/list-forms/list-forms.mjs`	Switched from mutating API results to aggregating into a local `forms` array across pages; updated summary to use `forms.length`; returned `forms`; version bump 0.0.7 → 0.0.8.
Package Version Bump `components/hubspot/package.json`	Bumped package version 1.7.5 → 1.7.6; no other changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as User
  participant A as ListForms Action
  participant H as HubSpot Forms API

  U->>A: Invoke list-forms
  A->>H: GET /forms?page=1
  H-->>A: results[], paging
  note over A: Initialize local accumulator: forms = []
  loop For each page
    A->>A: Append page results to forms
    A->>H: GET next page (if paging)
    H-->>A: results[], paging
  end
  A-->>U: Return forms (aggregated)
  note over A,U: Summary uses forms.length

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hop through pages, one by one,
Collecting forms till work is done.
No more empty paws or sighs—
A tidy basket, growing in size.
Version bumped, carrots raised high—
Forms abound! A bug goodbye. 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description contains only "Resolves #18392" and does not follow the repository's required description template which expects a "## WHY" section. It lacks an explanation of the root cause, a summary of the code changes, and any test or verification steps that demonstrate the fix. Because the required contextual information is missing, the description is incomplete and should be expanded before merging.	Please update the PR description to follow the repository template by adding a "## WHY" section that explains the root cause and the behavioral change introduced. Include a brief summary of the files changed, the approach taken to fix the bug, the linked issue number, and the tests or verification steps used to confirm the fix. Also note the package version bump and any changelog or release notes if applicable.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "Hubspot - bug fix to list-forms action" succinctly identifies the primary change as a bug fix to the Hubspot list-forms action. It is concise, a single sentence, and directly matches the modifications in components/hubspot/actions/list-forms/list-forms.mjs that adjust how API results are accumulated and returned. This phrasing is specific enough for a teammate scanning the PR history to understand the main purpose of the change.
Linked Issues Check	✅ Passed	Issue #18392 reports that the Hubspot "list forms" action always returns an empty list and requests a code fix. The change in components/hubspot/actions/list-forms/list-forms.mjs introduces a local "forms" accumulator, appends API page items into it instead of mutating the API-provided results array, and returns "forms", which directly targets the described failure mode. Based on the provided summaries, these code changes satisfy the linked issue's primary coding objective.
Out of Scope Changes Check	✅ Passed	The raw summary shows modifications limited to components/hubspot/actions/list-forms/list-forms.mjs and components/hubspot/package.json. Both edits are directly related to the bug fix: the first implements the behavioral fix and the second bumps the package version. There are no other modified files listed that would indicate unrelated or out-of-scope changes.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch issue-18392

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

components/hubspot/actions/list-forms/list-forms.mjs (3)

27-33: Good fix: local accumulator resolves empty-list bug; tighten params construction.
Avoid sending undefined query params.

Apply:

-    const forms = [];
+    const forms = [];
@@
-    const params = {
-      archived: this.archived,
-    };
+    const params = {};
+    if (this.archived !== undefined) params.archived = this.archived;

Optional (verify HubSpot max page size): set per-page limit to reduce requests.

     do {
+      // Page-size hint; verify max allowed by API (often 100)
+      params.limit = Math.min(this.maxResults - count, 100);
       const {
         paging, results,
       } = await this.hubspot.listMarketingForms({
         $,
         params,
       });

Would you confirm the max allowed limit for the Forms API and adjust the 100 if needed?

---

45-51: Simplify accumulation and avoid per-item counting.
Push a sliced batch instead of looping.

Apply:

-      for (const item of results) {
-        forms.push(item);
-        count++;
-        if (count >= this.maxResults) {
-          break;
-        }
-      }
+      const remaining = this.maxResults - count;
+      const take = Math.min(results.length, remaining);
+      forms.push(...results.slice(0, take));
+      count += take;

---

52-54: Guard optional chaining on next and only set after when present.
Prevents potential TypeError if paging exists without next, and avoids sending after=undefined.

Apply:

-      hasMore = paging?.next.after;
-      params.after = paging?.next.after;
-    } while (hasMore && count < this.maxResults);
+      const nextAfter = paging?.next?.after;
+      if (nextAfter) params.after = nextAfter;
+      else delete params.after;
+    } while (params.after && count < this.maxResults);

Optional: rename hasMore → nextAfter for clarity throughout.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 69eb39d and 281c69c.

📒 Files selected for processing (2)

• components/hubspot/actions/list-forms/list-forms.mjs (4 hunks)
• components/hubspot/package.json (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: Verify TypeScript components
• GitHub Check: Publish TypeScript components
• GitHub Check: Lint Code Base
• GitHub Check: pnpm publish

🔇 Additional comments (4)

components/hubspot/package.json (1)

3-3: Version bump aligned with action changes — LGTM.
No other fields changed; this matches the action’s 0.0.8 bump.

components/hubspot/actions/list-forms/list-forms.mjs (3)

8-8: Action version bump is appropriate.
Matches the package bump; no concerns.

---

58-60: Nice summary UX.
Pluralization logic is correct.

---

62-62: Return value is correct.
Returning forms matches the new accumulator.