- 
                Notifications
    
You must be signed in to change notification settings  - Fork 5.5k
 
[Upgrade] Migrate Tellent HR to new Authentication #18913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
  | 
    
          
WalkthroughKiwiHR component versions bumped to 1.0.0; GraphQL endpoint now built from the configured subdomain (https://{subdomain}.kiwihr.com/api/graphql); API key header changed to lowercase  Changes
 Sequence Diagram(s)sequenceDiagram
    autonumber
    participant Component as KiwiHR Component
    participant App as kiwihr.app.mjs
    participant GraphQL as kiwihr GraphQL
    Note over Component,App: Prepare request using this.kiwihr.$auth
    Component->>App: provide query/data
    App->>App: construct URL: https://${subdomain}.kiwihr.com/api/graphql
    App->>GraphQL: POST\nHeader: x-api-key: <api_key>\nBody: GraphQL query
    GraphQL-->>App: Response
    App-->>Component: Response payload
    Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 
 Poem
 Pre-merge checks and finishing touches❌ Failed checks (1 warning)
 ✅ Passed checks (4 passed)
 ✨ Finishing touches
 🧪 Generate unit tests (beta)
 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
 🚧 Files skipped from review as they are similar to previous changes (2)
 ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
 🔇 Additional comments (2)
 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment   | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
components/kiwihr/actions/create-employee/create-employee.mjs(1 hunks)components/kiwihr/actions/update-employee-record/update-employee-record.mjs(1 hunks)components/kiwihr/kiwihr.app.mjs(1 hunks)components/kiwihr/package.json(1 hunks)components/kiwihr/sources/new-employee/new-employee.mjs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Lint Code Base
 - GitHub Check: Verify TypeScript components
 - GitHub Check: pnpm publish
 - GitHub Check: Publish TypeScript components
 
🔇 Additional comments (4)
components/kiwihr/actions/update-employee-record/update-employee-record.mjs (1)
9-9: LGTM! Appropriate version bump.The patch version increment correctly reflects the authentication migration changes without breaking the action's interface.
components/kiwihr/package.json (1)
3-3: LGTM! Appropriate package version bump.The minor version increment correctly reflects the authentication migration changes across the KiwiHR integration.
components/kiwihr/actions/create-employee/create-employee.mjs (1)
9-9: LGTM! Appropriate version bump.The patch version increment correctly reflects the authentication migration changes without breaking the action's interface.
components/kiwihr/sources/new-employee/new-employee.mjs (1)
9-9: LGTM! Appropriate version bump.The patch version increment correctly reflects the authentication migration changes without breaking the source's interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break existing flows when updated - I think it should get a major version bump (i.e. 1.0.0)
72b025d    to
    91118cc      
    Compare
  
    | 
           /approve  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
components/kiwihr/actions/create-employee/create-employee.mjs(1 hunks)components/kiwihr/actions/update-employee-record/update-employee-record.mjs(1 hunks)components/kiwihr/kiwihr.app.mjs(1 hunks)components/kiwihr/package.json(1 hunks)components/kiwihr/sources/new-employee/new-employee.mjs(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- components/kiwihr/kiwihr.app.mjs
 - components/kiwihr/package.json
 - components/kiwihr/sources/new-employee/new-employee.mjs
 
🔇 Additional comments (2)
components/kiwihr/actions/create-employee/create-employee.mjs (1)
9-9: LGTM! Version bump aligns with authentication migration.The version bump to "0.0.3" appropriately indicates that this action now works with the updated authentication approach implemented in the kiwihr app connector.
components/kiwihr/actions/update-employee-record/update-employee-record.mjs (1)
9-9: LGTM! Version bump aligns with authentication migration.The version bump to "0.0.3" appropriately indicates that this action now works with the updated authentication approach implemented in the kiwihr app connector.
        
          
                components/kiwihr/actions/update-employee-record/update-employee-record.mjs
          
            Show resolved
            Hide resolved
        
      91118cc    to
    766b7cf      
    Compare
  
    | 
           /approve  | 
    
WHY
Resolves #18904
Summary by CodeRabbit
Bug Fixes
Chores