-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Woocommerce - Add GET request to certain Instant Webhook-Based Sources #3396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
feyzullah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michelle0927 I added just one comment. Can you please check?
| async listProducts(page) { | ||
| return this.listResources(`products?page=${page}`); | ||
| async listProducts(params = null) { | ||
| const q = querystring.stringify(params); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess querystring is deprecated. Would you mind using query-string or something similar?
feyzullah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
|
Hi everyone, all test cases are passed! Ready for release! Test report |
Resolves #3344