Skip to content

Conversation

@michelle0927
Copy link
Collaborator

@michelle0927 michelle0927 commented Jul 11, 2022

Resolves #3344

@michelle0927 michelle0927 self-assigned this Jul 11, 2022
@vercel
Copy link

vercel bot commented Jul 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pipedream-docs ✅ Ready (Inspect) Visit Preview Jul 11, 2022 at 7:15PM (UTC)
pipedream-docs-redirect-do-not-edit ✅ Ready (Inspect) Visit Preview Jul 11, 2022 at 7:15PM (UTC)

@dylburger
Copy link
Contributor

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

@feyzullah feyzullah self-requested a review July 11, 2022 18:24
Copy link
Contributor

@feyzullah feyzullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michelle0927 I added just one comment. Can you please check?

async listProducts(page) {
return this.listResources(`products?page=${page}`);
async listProducts(params = null) {
const q = querystring.stringify(params);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess querystring is deprecated. Would you mind using query-string or something similar?

Copy link
Contributor

@feyzullah feyzullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
Woocommerce_3344_1848.pdf

@michelle0927 michelle0927 merged commit f90089c into master Jul 14, 2022
@michelle0927 michelle0927 deleted the woocommerce-3344 branch July 14, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TRIGGER] woocommerce

5 participants