Release v0.6.5#38
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Check if versions match | ||
| if [[ "$PR_VERSION" != "$RELEASE_VERSION" ]]; then | ||
| echo "❌ ERROR: Version in pyproject.toml ($PR_VERSION) does not match source release branch version ($RELEASE_VERSION)" | ||
| echo "❌ ERROR: Version in pyproject.toml ($PR_VERSION) does not match release branch version ($RELEASE_VERSION)" | ||
| exit 1 |
There was a problem hiding this comment.
When the source branch is not named like release/v*, the Get branch info step exits early after printing “skipping version check” and never populates source_release_version, but the Check version matches release branch block still runs unconditionally and compares the pyproject version against that empty string, triggering the exit-1 path. As a result every normal PR to main now fails this workflow instead of being skipped as intended.
Useful? React with 👍 / 👎.
2 participants
No description provided.