Skip to content

Refactor/generalize new inference system#278

Merged
lchoquel merged 12 commits into
devfrom
refactor/Generalize-new-inference-system
Sep 18, 2025
Merged

Refactor/generalize new inference system#278
lchoquel merged 12 commits into
devfrom
refactor/Generalize-new-inference-system

Conversation

@lchoquel
Copy link
Copy Markdown
Member

Added

  • Unified OCR system using model handles instead of separate OcrHandle enum
  • ModelType enum supporting LLM and TEXT_EXTRACTOR types
  • Enhanced error handling in library loading with better validation messages
  • Config template management with config-template and cft Makefile targets

Changed

  • OCR system now uses InferenceModelSpec with unified model handles
  • Renamed get_llm_deck() to get_model_deck() and updated parameter names from llm_handle to model_handle
  • Simplified OCR worker factory using plugin SDK matching
  • Enhanced plugin system compatibility with InferenceModelSpec
  • Improved error messages throughout system

Removed

  • Legacy OCR classes: OcrHandle, OcrPlatform, OcrEngine, OcrEngineFactory
  • Obsolete configuration fields and setup methods
  • PipelexFileError exception class

@lchoquel lchoquel marked this pull request as ready for review September 18, 2025 06:52
Copy link
Copy Markdown
Member

@thomashebrard thomashebrard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Comment thread pipelex/cogt/ocr/ocr_worker_factory.py
@lchoquel lchoquel merged commit d121b39 into dev Sep 18, 2025
14 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 18, 2025
@lchoquel lchoquel deleted the refactor/Generalize-new-inference-system branch September 18, 2025 11:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants