Add inference models & template optional insertion#32
Merged
Conversation
…ne, model, platform
thomashebrard
approved these changes
Jun 2, 2025
Member
thomashebrard
left a comment
thomashebrard
left a comment
There was a problem hiding this comment.
Really nice!
non breaking remarks
Comment on lines
+41
to
+45
| background: Background = Field(strict=False) | ||
| quality: Optional[Quality] = Field(default=None, strict=False) | ||
| nb_steps: Optional[int] = Field(default=None, gt=0) | ||
| guidance_scale: float = Field(..., gt=0) | ||
| is_safety_checker_enabled: bool | ||
| is_moderated: bool |
Member
There was a problem hiding this comment.
Maybe this model would need docstrings to explain the fields
| from pipelex.pipe_operators.pipe_operator import PipeOperator | ||
|
|
||
| # TODO: refacto this as part of the PipeImgGen blueprint/params | ||
| IMGG_PROMPT_NAME = "imgg_prompt" |
Member
There was a problem hiding this comment.
"imgg" is kind of confusing. Hard to guess it means “image generation"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
@?for optional insertion: if the variable doesn't exist in the context, nothing is inserted (instead of raising an exception).Models
Base Library
page_viewimages, i.e. pages rendered as images (very useful for using Vision down the line). This one used to be defined in the cookbook samples so, congrats on the promotion.Refactor
Fixes
Dependencies
🔄 Type of Change
🧪 Tests