Conversation
Setup target `make test-xdist` = Run unit tests with xdist, make it the default for shorthand `make t`. The old make t is now make tp (test-with-prints)
|
|
||
|
|
||
| class SpecialMissionId(StrEnum): | ||
| class SpecialPipelineId(StrEnum): |
Member
There was a problem hiding this comment.
Notableinstead of Special?
|
|
||
|
|
||
| class Pipeline(BaseModel): | ||
| pipeline_run_id: str |
Member
There was a problem hiding this comment.
do we really need "pipeline" here ?
I am trying to imagine this code:
my_pipeline = Pipeline()
my_pipeline.pipeline_run_id
seems heavy
Member
Author
There was a problem hiding this comment.
not strictly but for a while, while we transition from the run_pipe API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
make test-xdist= Run unit tests with xdist, make it the default for shorthandmake t. The old make t is now make tp (test-with-prints)🔄 Type of Change