Skip to content

Be more lax on having domain definition: it's now Optional#73

Merged
lchoquel merged 2 commits intodevfrom
feature/Be-more-lax-on-having-domain-definition
Jun 10, 2025
Merged

Be more lax on having domain definition: it's now Optional#73
lchoquel merged 2 commits intodevfrom
feature/Be-more-lax-on-having-domain-definition

Conversation

@lchoquel
Copy link
Copy Markdown
Member

📝 Description

  • Be more lax on having domain definition: it's now Optional

🔄 Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • 📚 Documentation update
  • 🧹 Code refactor
  • ⚡ Performance improvement
  • ✅ Test update

🧪 Tests

  • tests/test_pipelines/failure_modes.toml has no domain definition set, and it's OK

@lchoquel lchoquel requested a review from thomashebrard June 10, 2025 10:50
Copy link
Copy Markdown
Member

@thomashebrard thomashebrard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@lchoquel lchoquel merged commit bd9d6b3 into dev Jun 10, 2025
13 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 10, 2025
@lchoquel lchoquel deleted the feature/Be-more-lax-on-having-domain-definition branch June 10, 2025 13:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants