claude-opus-4-7#823
Merged
Merged
Conversation
…lify standalone asset caching Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Greptile Summary
Confidence Score: 5/5Safe to merge — no P0/P1 issues; all changes are additive config and a clean refactor. The only finding is a P2 clarification question about whether the "latest" alias entries in google.toml are gateway-only or also intended for direct Google API use. No logic bugs, data integrity issues, or breaking changes were found. pipelex/kit/configs/inference/backends/google.toml — the three "latest" alias entries lack explicit model_id and may not resolve correctly against the direct Google API. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[ReasoningEffort] --> B{GoogleLLMWorker
_build_thinking_config}
B --> C{reasoning_effort set?}
C -- yes --> D{ThinkingMode?}
C -- no --> E{reasoning_budget set?}
E -- yes --> F[_build_thinking_config_for_budget
ThinkingConfig budget]
E -- no --> G[return None]
D -- MANUAL --> H[get_reasoning_level
effort → level string]
H --> I{level is None
disabled?}
I -- yes --> J[ThinkingConfig budget=0]
I -- no --> K[get_reasoning_budget
prompting_target + effort]
K --> L[ThinkingConfig thinking_budget]
D -- ADAPTIVE --> M[get_reasoning_level
effort → ThinkingLevel]
M --> N{level is None?}
N -- yes --> O[ThinkingConfig budget=0]
N -- no --> P[ThinkingConfig thinking_level
MINIMAL / LOW / MEDIUM / HIGH]
D -- NONE --> Q[raise LLMCapabilityError]
Prompt To Fix All With AIThis is a comment left during a code review.
Path: pipelex/kit/configs/inference/backends/google.toml
Line: 91-111
Comment:
**Latest-alias entries rely on name-fallback for `model_id`**
`gemini-pro-latest`, `gemini-flash-latest`, and `gemini-flash-lite-latest` have no explicit `model_id`, so `InferenceModelSpecFactory` will fall back to the section name (line 99: `blueprint.model_id or name`). For Pipelex Gateway this is fine — the gateway resolves these aliases. For a direct Google Gemini API backend, though, the string `"gemini-pro-latest"` (without a version number) is sent as-is to Google's API; if Google doesn't recognise it as a valid model alias the call will fail at runtime.
Consider either adding an explicit `model_id` (e.g. pointing to the current latest concrete model ID) or a comment clarifying these entries are gateway-only.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "Merge branch 'dev' into release/v0.24.0" | Re-trigger Greptile |
There was a problem hiding this comment.
1 issue found across 15 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="pipelex/kit/configs/inference/backends/google.toml">
<violation number="1" location="pipelex/kit/configs/inference/backends/google.toml:65">
P2: Renaming this preset drops the existing `gemini-3.0-flash-preview` handle and breaks backward compatibility. Keep the old name as an alias or retain the original preset key.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
thomashebrard
previously approved these changes
Apr 17, 2026
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
thomashebrard
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds Gemini 3.1 models and “latest” aliases for Google, promotes
claude-4.7-opusto default premium, and correctly maps Google’s MINIMAL reasoning level. Also simplifies ReactFlow asset caching and improves error messages when a local model deck is stale.New Features
gemini-3.1-flash-liteandgemini-3.1-proto Google backend configs and test profiles.gemini-pro-latest,gemini-flash-latest, andgemini-flash-lite-latestaliases; switched LLM deck defaults to use them (e.g.,best-gemini = gemini-pro-latest, small vision/creative nowgemini-flash-latest, cheap retrieval usesgemini-flash-lite-latest).claude-4.7-opusasbest-claudeand as default for premium, premium-vision, and premium-structured.ReasoningEffort.MINIMALto Google’sThinkingLevel.MINIMAL; enum and default map updated; tests and docs updated.Refactors
functools.cacheand improved ModelNotFoundError guidance for stale local decks (pipelex init inferencehint).gemini-3.0-flash-previewtogemini-3.0-flash; regenerated gateway model docs.Written for commit 0891ac9. Summary will update on new commits.