Skip to content

feat: lean CLAUDE.md by default + standalone variant for contributors#923

Merged
lchoquel merged 4 commits into
devfrom
feature/Rules
May 20, 2026
Merged

feat: lean CLAUDE.md by default + standalone variant for contributors#923
lchoquel merged 4 commits into
devfrom
feature/Rules

Conversation

@lchoquel
Copy link
Copy Markdown
Member

@lchoquel lchoquel commented May 20, 2026

Summary

  • Make make rules produce a lean CLAUDE.md that omits Python and pytest standards (Pipelex maintainers already get those from the workspace's .claude/rules/).
  • Keep AGENTS.md with the full standards inline for non-Claude agents.
  • Add make rules-claude-standalone for contributors without the workspace — regenerates CLAUDE.md with everything inline.
  • Drop tdd.md from all generated rule sets.

Implementation: uses the existing per-target set override mechanism ([agent_rules.targets.<id>.sets]) plus a new --targets CLI filter on pipelex-dev kit rules so the standalone command regenerates only CLAUDE.md.

Test plan

  • make tb — config boot sanity
  • make agent-check — ruff, plxt, pyright, mypy all clean
  • pytest tests/unit/pipelex/kit/ tests/integration/pipelex/kit/ — 22 passed (incl. 4 new in test_target_set_overrides.py)
  • make rules → lean CLAUDE.md (no Python/pytest/TDD), AGENTS.md keeps full standards (TDD removed)
  • make rules-claude-standalone → full CLAUDE.md, AGENTS.md untouched
  • make check-rules → passes against the lean baseline

🤖 Generated with Claude Code


Summary by cubic

Make CLAUDE.md lean by default and add a standalone option for contributors. Adds --targets to pipelex-dev kit rules and makes Cursor cleanup safer and idempotent.

  • New Features

    • make rules generates a lean CLAUDE.md; AGENTS.md keeps Python/pytest.
    • make rules-claude-standalone regenerates CLAUDE.md with the full ruleset (targets only claude).
    • pipelex-dev kit rules --targets updates a subset of preferred targets with validation; cleanup keep-set remains the full preferences.
    • Per-target sets for claude in index.toml: all (lean) and standalone (full).
    • Drop tdd.md. Cursor .mdc files add pipelex_managed: true; cleanup also honors agent_rules.deprecated_rule_stems (e.g. ["tdd"]) and removes pre-marker files safely.
  • Migration

    • Commit the lean CLAUDE.md from make rules; this is canonical.
    • If you’re contributing without the workspace, run make rules-claude-standalone locally; do not commit it.
    • Use pipelex-dev kit rules --targets claude to limit regeneration when needed.

Written for commit df48c52. Summary will update on new commits. Review in cubic

- Drop tdd.md from all generated rule sets
- Add [agent_rules.targets.claude.sets] with `all` (lean) and `standalone` (full); CLAUDE.md no longer duplicates Python and pytest standards that workspace users already get from .claude/rules/
- Add --targets CLI filter to `pipelex-dev kit rules` to constrain which preferred targets get regenerated
- Add `make rules-claude-standalone` for contributors without the Pipelex workspace
- Document the lean/standalone split in CONTRIBUTING.md
- Cover lean/standalone behavior with a new integration test

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 20, 2026

Greptile Summary

This PR changes how Pipelex agent rules are generated and adds a standalone Claude rules option. The main changes are:

  • Lean CLAUDE.md by default while keeping full standards in AGENTS.md.
  • Add make rules-claude-standalone and a --targets CLI filter for selective regeneration.
  • Remove TDD rules from generated rule sets.
  • Add Cursor cleanup markers and deprecated rule tombstones for stale generated files.
  • Add gemini-3.5-flash to the Google backend config and generated model references.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
pipelex/cli/dev_cli/commands/kit_cmd.py Keeps the cleanup keep-set separate from the filtered update targets.
pipelex/kit/cursor_rules.py Adds managed markers and deprecated-stem cleanup for generated Cursor rule files.
pipelex/kit/index.toml Defines lean and standalone Claude rule sets and removes TDD from generated sets.
.pipelex/inference/backends/google.toml Adds the gemini-3.5-flash Google model entry.

Reviews (3): Last reviewed commit: "Merge branch 'dev' into feature/Rules" | Re-trigger Greptile

Comment thread pipelex/cli/dev_cli/commands/kit_cmd.py Outdated
Comment thread pipelex/kit/index.toml
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 157e2f62c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pipelex/kit/index.toml
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 8 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread pipelex/cli/dev_cli/commands/kit_cmd.py Outdated
Comment thread pipelex/kit/cursor_rules.py Outdated
@lchoquel lchoquel merged commit e3ed1f3 into dev May 20, 2026
28 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
@lchoquel lchoquel deleted the feature/Rules branch May 20, 2026 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants