Updated WebSocketHandler ssl to work with Python 3.12+ #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced ssl.wrap_socket() with the new ssl.SSLContext approach in WebSocketHandler __init__ as Python 3.12+ no longer supports the ssl.wrap_socket() function.
|
Hi @Pithikos, it would be great if you could release a new version containing this PR to add support for Python 3.12+. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
ssl.wrap_socket()with the newssl.SSLContextapproach inWebSocketHandler__init__as Python 3.12+ no longer supports thessl.wrap_socket()function.The
ssl.wrap_socket()function was removed in Python 3.12, making it impossible now to establish a secure websocket connection. I've replaced the script inside thetrywith the new ssl context approach.I also added an
exceptfor handlingFileNotFoundErrorand another one for thessl.SSLErrorto clarify error messages.