Skip to content

Conversation

@RINNE-TAN
Copy link
Member

  • impl multi trait
  • generic trait bound multi

@Chronostasys Chronostasys force-pushed the master branch 2 times, most recently from eadad08 to 27bbded Compare April 23, 2023 13:12
@RINNE-TAN RINNE-TAN force-pushed the feat/trait_bound_multi branch from 939eb3d to ad9375b Compare April 26, 2023 06:23
@RINNE-TAN RINNE-TAN changed the title [WIP] trait bound multi trait bound multi Apr 26, 2023
@github-actions
Copy link

Benchmark for b230ecd

Click to view benchmark
Test Base PR %
multithreads(2) gc benchmark--65535 small objects(per thread) 1249.1±178.51µs 1410.7±353.09µs +12.94%
plimmixgc/multi-thread gc stress benchmark small objects 999.4±26.68ms 1002.6±38.83ms +0.32%
plimmixgc/singlethread gc stress benchmark small objects 941.8±19.62ms 937.6±17.42ms -0.45%
singlethread gc benchmark--65535 small objects 1116.7±31.47µs 1103.8±38.73µs -1.16%
singlethread gc mark benchmark--65535 small objects 655.0±39.25µs 634.8±22.93µs -3.08%
singlethread gc sweep benchmark--65535 small objects 454.8±1.27µs 453.5±2.34µs -0.29%

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #278 (ad9375b) into master (f6d2c41) will increase coverage by 0.22%.
The diff coverage is 90.45%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
+ Coverage   87.27%   87.49%   +0.22%     
==========================================
  Files          98       98              
  Lines       16685    16823     +138     
==========================================
+ Hits        14561    14720     +159     
+ Misses       2124     2103      -21     
Impacted Files Coverage Δ
src/ast/builder/mod.rs 33.33% <ø> (ø)
src/ast/diag.rs 61.50% <ø> (ø)
src/nomparser/function.rs 99.12% <ø> (-0.17%) ⬇️
src/ast/node/implement.rs 81.97% <74.00%> (+2.99%) ⬆️
src/ast/node/interface.rs 88.35% <93.22%> (+1.54%) ⬆️
src/ast/node/types.rs 81.89% <93.75%> (-0.48%) ⬇️
src/ast/pltype.rs 86.96% <94.85%> (+2.52%) ⬆️
src/ast/builder/llvmbuilder.rs 90.69% <100.00%> (+0.24%) ⬆️
src/ast/builder/no_op_builder.rs 74.15% <100.00%> (ø)
src/ast/ctx.rs 90.71% <100.00%> (+0.04%) ⬆️
... and 4 more

... and 3 files with indirect coverage changes

@RINNE-TAN RINNE-TAN requested a review from Chronostasys April 26, 2023 06:39
Copy link
Member

@Chronostasys Chronostasys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

这段代码逻辑严密,思路清晰,少侠好身手!

@Chronostasys Chronostasys merged commit 5688476 into master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants