Improve how the sky and block lights are combined in the shader. #2442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This is an interesting one.
So far placing a lightsource in broad daylight (or in a brightly lit surface cave) had no effect at all.
With this patch placing a torch or another light source actually makes things (slightly) brighter.
Now, since the peak brightness is capped at one, this mostly affects the shadow areas, this does make the ambient occlusion weaker in these areas. But for dimmer light sources like the torch the difference is small and for brighter light source it seems reasonable that the ambient occlusion is reduced when the light is coming from multiple source.
This would help distinguish weak lights in a bright night (as noticed in #2440 (comment))
@ikabod-kee @careeoki I would like your opinions here as well. I decided to make this an independent PR in case #2440 is rejected, since I think this is a decent improvement either way.