Reload Part 2 | no autokick when /server restart (headless) #3278
Open
tillpp wants to merge 112 commits into
Open
Reload Part 2 | no autokick when /server restart (headless) #3278tillpp wants to merge 112 commits into
tillpp wants to merge 112 commits into
Conversation
Co-authored-by: IntegratedQuantum <43880493+IntegratedQuantum@users.noreply.github.com>
IntegratedQuantum
requested changes
Jun 29, 2026
Co-authored-by: IntegratedQuantum <43880493+IntegratedQuantum@users.noreply.github.com>
Co-authored-by: IntegratedQuantum <43880493+IntegratedQuantum@users.noreply.github.com>
Co-authored-by: IntegratedQuantum <43880493+IntegratedQuantum@users.noreply.github.com>
Co-authored-by: IntegratedQuantum <43880493+IntegratedQuantum@users.noreply.github.com>
IntegratedQuantum
requested changes
Jun 29, 2026
| connectionManager.pause(); | ||
| main.threadPool.clear(); | ||
|
|
||
| connectionManager.pause(); |
Member
There was a problem hiding this comment.
Doing this after clear adds a race condition, since new threadpool tasks may be added by connected players.
Why does player pausing need to happen after threadpool clear?
Contributor
Author
There was a problem hiding this comment.
i dont remember all interconnections, but user.pause does deinit stuff, that is still needed by threads on the main.threadPool
Contributor
Author
There was a problem hiding this comment.
we could do main.threadPool.clear twice, one before and after
Contributor
Author
There was a problem hiding this comment.
or i move it where i moved it now
Member
There was a problem hiding this comment.
I'm not happy with the outcome here, and I think it would be best to use a more robust mechanism, as proposed in #3321.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2026-06-23.15-31-30.mp4
TODOs: