Fix album art cropping in VeryThin and Thin widget layouts#50
Merged
Conversation
The album art in the VeryThinWidgetLayout and ThinWidgetLayout was being cropped because it had a fixed width of 56.dp but a variable height. This change modifies both layouts to make the album art a square, with its size dynamically calculated based on the widget's height minus the vertical padding. This ensures the album art is always circular (due to the corner radius) and is never cropped. Note: I was unable to run the automated tests due to a missing Android SDK configuration in the execution environment. However, the changes are highly localized to the UI of two specific widgets and have been carefully reviewed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The album art in the VeryThinWidgetLayout and ThinWidgetLayout was being cropped because it had a fixed width of 56.dp but a variable height.
This change modifies both layouts to make the album art a square, with its size dynamically calculated based on the widget's height minus the vertical padding. This ensures the album art is always circular (due to the corner radius) and is never cropped.
Note: I was unable to run the automated tests due to a missing Android SDK configuration in the execution environment. However, the changes are highly localized to the UI of two specific widgets and have been carefully reviewed.