Skip to content

feat(smtp): add setting to ignore cert validation #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pkheav merged 2 commits into from
May 18, 2021
Merged

feat(smtp): add setting to ignore cert validation #161

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e695e6
feat(smtp): add setting to ignore cert validation
pkheav May 17, 2021
24747e9
fix(smtp): add check for setting
pkheav May 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions drivers/place/smtp.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ class Place::Smtp < PlaceOS::Driver
# host: "smtp.host",
# port: 587,
tls_mode: EMail::Client::TLSMode::STARTTLS.to_s,
ssl_verify_ignore: false,
username: "", # Username/Password for SMTP servers with basic authorization
password: "",

Expand All @@ -41,6 +42,7 @@ class Place::Smtp < PlaceOS::Driver
@port : Int32 = 587
@tls_mode : EMail::Client::TLSMode = EMail::Client::TLSMode::STARTTLS
@send_lock : Mutex = Mutex.new
@ssl_verify_ignore : Bool = false

def on_load
on_update
Expand All @@ -62,6 +64,7 @@ class Place::Smtp < PlaceOS::Driver
@host = setting?(String, :host) || host
@port = setting?(Int32, :port) || port
@tls_mode = setting?(EMail::Client::TLSMode, :tls_mode) || tls_mode
@ssl_verify_ignore = setting?(Bool, :ssl_verify_ignore) || false

@smtp_client = new_smtp_client

Expand All @@ -79,6 +82,7 @@ class Place::Smtp < PlaceOS::Driver
end

email_config.use_tls(@tls_mode)
email_config.tls_context.verify_mode = OpenSSL::SSL::VerifyMode::None if @ssl_verify_ignore

EMail::Client.new(email_config)
end
Expand Down