feat(placeos/room-events): add list_users func#461
Merged
Conversation
stakach
requested changes
Sep 22, 2023
Co-authored-by: Stephen von Takach <steve@place.technology>
Contributor
Author
|
tested e2e ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some role based accounts running the Booking panel app (via api key) may not have MS Graph API delegated permissions to query the AAD user directory (e.g. PlaceOS local accounts).
This change allows those apps to query users via a driver exec instead of via a staff-api call. A corresponding frontend change would also be required.