fix(placeos/visitor-mailer): determine host name with calendar driver…#462
Merged
Conversation
…, not staff-api. As kiosk role-based account may not have access to AAD user search.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows kiosk apps using API Keys associated with placeos local role based accounts (no MS Graph api delegated access) to determine the host name, using an AAD lookup via calendar driver instead of staff-api driver (delegated permissions).
Note that before deploying this visitor mailer driver update to any clients that REQUIRE the hostname lookup to use staff-api instead of calendar driver, be sure to set setting:
determine_host_name_using: "staff-api-driver"to ensure that it functions as it used to.