feat(room_at_capacity_mailer): [PPT-1721|PPT-1852] notify when people_count equals or exceeds capacity#540
Merged
Conversation
stakach
requested changes
Feb 12, 2025
Member
stakach
left a comment
There was a problem hiding this comment.
This will send an email every 20 seconds while the room is at capacity
We probably want to do 2 things:
- track where rooms are at or over capacity (system_id => over_capactity_detected_count)
increment the count every poll - only send an email when the over_capactity_detected_count == 2 (i.e. 5min polling means email sent when over capacity for 10min)
- if a room drops below capacity then delete the system_id from the hash or set to 0
We might also want to ensure only one email is sent per meeting?
but i think the above should work well enough
Contributor
Author
|
There is a |
stakach
requested changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.