Skip to content

fix(floorsense/desk_list): handle controllers lacking desk api #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stakach merged 3 commits into from
Mar 28, 2025
Merged

fix(floorsense/desk_list): handle controllers lacking desk api #550

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9d4ccf
fix(floorsense/desk_list): handle controllers lacking desk api
viv-4 Mar 28, 2025
173983c
chore(floorsense/desk_list): simplify desk api error checks
viv-4 Mar 28, 2025
34e141b
fix(floorsense/desk_list): nil error message & syntax
viv-4 Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions drivers/floorsense/desks_websocket.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,8 +753,12 @@ class Floorsense::DesksWebsocket < PlaceOS::Driver
end

def desk_list(controller_id : String | Int32 | Int64)
response = get("/restapi/desk-list?cid=#{controller_id}", headers: default_headers)
parse response, Array(DeskInfo)
response = get("/restapi/desk-list?cid=#{controller_id}", headers: default_headers)
parse response, Array(DeskInfo)
rescue error
# code 34 "unknown command" indicates the desk api is unavailable
raise error unless error.message.try &.includes?("34")
[] of DeskInfo
end

def desk_info(desk_key : String)
Expand Down
Loading