Skip to content

fix(webrtc): recaptcha error handling#433

Merged
stakach merged 1 commit intomasterfrom
fix/webrtc_recaptcha_error_handling
May 8, 2026
Merged

fix(webrtc): recaptcha error handling#433
stakach merged 1 commit intomasterfrom
fix/webrtc_recaptcha_error_handling

Conversation

@chillfox
Copy link
Copy Markdown
Contributor

@chillfox chillfox commented May 5, 2026

Fix reCAPTCHA enforcement in WebRTC guest_entry: the generic rescue error was catching and swallowing Error::RecaptchaFailed alongside transient network errors, allowing guests to obtain a valid JWT even when reCAPTCHA verification failed. This adds a specific rescue error : Error::RecaptchaFailed clause to re-raise it before the generic rescue.

@chillfox chillfox self-assigned this May 5, 2026
@github-actions github-actions Bot added the type: bug something isn't working label May 5, 2026
@chillfox chillfox requested a review from stakach May 5, 2026 06:10
@stakach stakach merged commit 3137c47 into master May 8, 2026
9 of 11 checks passed
@stakach stakach deleted the fix/webrtc_recaptcha_error_handling branch May 8, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants