ScriptEngineManager#35
Closed
Tanguygab wants to merge 2 commits into
Closed
Conversation
Author
|
I've just tested and it doesn't seem to detect JSEngnie anyway, I'll try to search a bit more |
Author
|
welp, it does work in the end, you just have to use |
Member
|
Does this work on Java 16? |
Author
|
that's what I tried on |
Member
|
Alrighty well thank you for your time and consideration but internally we have already discussed how we plan to move forward with this expansion and our changes will be implemented in the next week or so. |
Author
|
Alright! I'll just close the pr then, looking forward to that update 👀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey 🖐

I was looking through the code to try to understand why in the world wouldn't the expansion detect Graal.js nor the JSEngine plugin and I've noticed that the expansion just created a new instance of the ScriptEngineManager while it could (should?) use the Bukkit ServicesManager.
I've realized that it might have been the cause JSEngine states it on its Spigot page
So I tried to use that, and it turns out it detected Graal.js correctly!

Idk with JSEngine since I was lazy to try x) but I guess it should work as well.
Anyways, hopefully this helps =)