Skip to content

ScriptEngineManager#35

Closed
Tanguygab wants to merge 2 commits into
PlaceholderAPI:masterfrom
Tanguygab:master
Closed

ScriptEngineManager#35
Tanguygab wants to merge 2 commits into
PlaceholderAPI:masterfrom
Tanguygab:master

Conversation

@Tanguygab
Copy link
Copy Markdown

Hey 🖐
I was looking through the code to try to understand why in the world wouldn't the expansion detect Graal.js nor the JSEngine plugin and I've noticed that the expansion just created a new instance of the ScriptEngineManager while it could (should?) use the Bukkit ServicesManager.
I've realized that it might have been the cause JSEngine states it on its Spigot page
image

So I tried to use that, and it turns out it detected Graal.js correctly!
image
Idk with JSEngine since I was lazy to try x) but I guess it should work as well.
Anyways, hopefully this helps =)

@Tanguygab
Copy link
Copy Markdown
Author

I've just tested and it doesn't seem to detect JSEngnie anyway, I'll try to search a bit more

@Tanguygab
Copy link
Copy Markdown
Author

Tanguygab commented May 29, 2021

welp, it does work in the end, you just have to use JavaScript as engine, case sensitive, idk why js didn't work while it was listed nor why it doesn't want to show up under the Displaying all script engine factories. message...

@darbyjack
Copy link
Copy Markdown
Member

Does this work on Java 16?

@Tanguygab
Copy link
Copy Markdown
Author

that's what I tried on

@darbyjack
Copy link
Copy Markdown
Member

Alrighty well thank you for your time and consideration but internally we have already discussed how we plan to move forward with this expansion and our changes will be implemented in the next week or so.

@Tanguygab
Copy link
Copy Markdown
Author

Alright! I'll just close the pr then, looking forward to that update 👀

@Tanguygab Tanguygab closed this May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants