fix: nashorn-core shading as standalone javascript engine for java 15#38
Closed
Maximvdw wants to merge 1 commit into
Closed
fix: nashorn-core shading as standalone javascript engine for java 15#38Maximvdw wants to merge 1 commit into
Maximvdw wants to merge 1 commit into
Conversation
Author
|
solves issue #34 without any JS changes - since it still uses nashorn. This would ensure better compatibility with already established scripts. File size of the expansion would increase to 2MB , but this is a small price to pay for compatibility. |
Closed
Member
|
Closing in favor of #36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Java 15+ compatibility using nashorn-core as a shaded dependency. Engine manager adds "nashorn".
Current PR compiled with Java 15 for nashorn-core compatibility.