Use ExpansionType check for persistence#1071
Open
Andre601 wants to merge 3 commits into
Open
Conversation
BlitzOffline
requested changes
Jul 7, 2024
BlitzOffline
approved these changes
Jul 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Type
Description
Closes N/A
PlaceholderAPI is still solely relying on the
persist()boolean method to check if an expansion should be unregistered or not.And as prooven by #1070 is this a faulty aproach, as a dev missing the override or not setting it to return true can cause an internal expansion to unregister and not register again due to it being internal.
Since we now have an Enum to set an expansion's type to be either Internal (Default) or external, is there no need for this extra method to be needed, hence why this PR deprecates it and updates the expansion manager to check not only for
persist()being true, but also for when it is marked internal.This also adds a warning for the case where an expansion is marked external, but has
persist()return true, which it should never be.