Skip to content

Formatting, spacing, final modifiers, and a few code fixes#131

Merged
LemmoTresto merged 7 commits into
PlaceholderAPI:masterfrom
Draycia:master
Oct 16, 2019
Merged

Formatting, spacing, final modifiers, and a few code fixes#131
LemmoTresto merged 7 commits into
PlaceholderAPI:masterfrom
Draycia:master

Conversation

@Draycia
Copy link
Copy Markdown
Contributor

@Draycia Draycia commented Jun 10, 2019

  • Use append instead of string concatenation in StringBuilder
  • Remove unnecessary casts in the PlaceholderAPI class
  • Add final modifiers to some fields
  • Ensure line width doesn't exceed a certain amount
  • Add spacing mostly where appropriate

Comment thread src/main/java/me/clip/placeholderapi/PlaceholderAPI.java
@darbyjack
Copy link
Copy Markdown
Member

Thanks for this. I'll look over it with clip in the coming days and hopefully, this will be pulled into the next update!

@extendedclip
Copy link
Copy Markdown
Member

Will follow up with this pr when I get home from vacation.

@LemmoTresto LemmoTresto merged commit ab97164 into PlaceholderAPI:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants