Skip to content

Remove Gson#485

Merged
PiggyPiglet merged 2 commits into
developmentfrom
fix/477-remove-gson
Apr 12, 2021
Merged

Remove Gson#485
PiggyPiglet merged 2 commits into
developmentfrom
fix/477-remove-gson

Conversation

@Andre601
Copy link
Copy Markdown
Collaborator

Pull Request

Type

  • Internal change (Doesn't affect end-user).
  • External change (Does affect end-user).
  • Wiki (Changes towards the Wiki).
  • Other: __________

Description

I made this PR now to finally get this rolling.
As described in #477 does PAPI have a chance of messing up bStats which may or may not break stats of all the other plugins that use bStats.
From what I gathered in the issue is the problem the relocated gson and the only reason gson is there is because of 1.7 support.

I say fuck 1.7! That version doesn't have any real reason to be supported on our end and finding a complicated solution (like making a separate jar... why?) just to still support it is imo not good at all.

This is a draft to keep a sort of discussion running so that we can (finally) decide on a solution. If there is a better solution without making PAPI too overcomplicated in terms of maintenance should this be mentioned.
I may open this for merge once we finally go to a proper point but my opinion is to finally drop 1.7 support. It's not worth the trouble in any way.

Closes #477

@Andre601 Andre601 marked this pull request as ready for review September 26, 2020 12:36
@Andre601
Copy link
Copy Markdown
Collaborator Author

Andre601 commented Jan 6, 2021

@darbyjack @extendedclip @PiggyPiglet Any input on this? Should we just drop 1.7 support? I think that really is the best option here.

@Andre601 Andre601 changed the base branch from master to development January 6, 2021 15:57
@PiggyPiglet PiggyPiglet merged commit 3a31c5c into development Apr 12, 2021
@Andre601 Andre601 deleted the fix/477-remove-gson branch May 6, 2021 17:28
@Andre601 Andre601 mentioned this pull request May 31, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PAPI gutting other plugins' and its own bStats

3 participants