Remove Gson#485
Merged
Merged
Conversation
Collaborator
Author
|
@darbyjack @extendedclip @PiggyPiglet Any input on this? Should we just drop 1.7 support? I think that really is the best option here. |
PiggyPiglet
approved these changes
Apr 12, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Type
Description
I made this PR now to finally get this rolling.
As described in #477 does PAPI have a chance of messing up bStats which may or may not break stats of all the other plugins that use bStats.
From what I gathered in the issue is the problem the relocated gson and the only reason gson is there is because of 1.7 support.
I say fuck 1.7! That version doesn't have any real reason to be supported on our end and finding a complicated solution (like making a separate jar... why?) just to still support it is imo not good at all.
This is a draft to keep a sort of discussion running so that we can (finally) decide on a solution. If there is a better solution without making PAPI too overcomplicated in terms of maintenance should this be mentioned.
I may open this for merge once we finally go to a proper point but my opinion is to finally drop 1.7 support. It's not worth the trouble in any way.
Closes #477