Improve bStats metrics#547
Closed
Andre601 wants to merge 4 commits into
Closed
Conversation
Collaborator
Author
|
I decided to now have the server brand as its own SimplePie Chart with the identifier Additionally does |
PiggyPiglet
approved these changes
Apr 12, 2021
Collaborator
Author
|
This won't be added in the near future, so I just close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Type
Description
Closes N/A
This PR changes a few things.
It first of all changes the
Versionclass to have a nestedTypeEnum which is used in thestaticofPlaceholderAPIPluginto determine the actual server type used.The code to do this has been borrowed from the Server-Expansion and currently supports Purpur, Tuinity, PaperMC and Spigot itself.
Next does
using_spigotnow return 3 different responses:yes (fork)when it is a Spigot fork (Currently PaperMC, Tuinity and Purpur)yesfor Spigot itselfnofor any other casesAll forks are currently treated as
isSpigot = true, so if that should be changed, let me know.The original
Version(String, boolean)Constructor has been deprecated in favour of theVersion(String, Version.Type)Constructor, but still works, with the class resulting in havingVersion(version, Type.SPIGOT)set when server is a Spigot server andVersion(version, Type.UNKNOWN)when it is not.Important
A new SimplePie Chart has been added. The identifier is
server_brandand it returns the Server Brand name, so a new Chart would need to be added to bStats to have these metrics working.