Skip to content

Import resources aswell as classes when loading an expansion jar #23

@PiggyPiglet

Description

@PiggyPiglet

Type

What kind of request is this? (Multiple selections possible)

  • Change to code (Internal).
    Changes to code that won't affect the end-user.

Info

What is the change?
Please provide as much information (including links, images and code-snippeds) as possible.

PlaceholderAPI currently loads expansions by looping through each jar with a JarInputStream, then manually adding any file that ends with .class to the class loader. I propose that this is replaced with an invocation of URLClassLoader#addURL with the jar's URL. A usage example can be found on my jar loading library.

This is an important change, as it will allow expansion developers to embed files in their jars, and use them without any extra hacking. e.g. configs

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions