Added bind main option to allow platforms to stop binding the main class#33
Closed
BomBardyGamer wants to merge 1 commit into
Closed
Added bind main option to allow platforms to stop binding the main class#33BomBardyGamer wants to merge 1 commit into
BomBardyGamer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the check for the platform being
Platform.SPONGE, which was not scalable, as other platforms may need to disable this binding, such as Velocity and Krypton, which both also bind the main class.I did think about just making the binding nullable, but that wouldn't work, since we need the binding for the
@Databinding.If anyone has any better ideas, feel free to suggest them.
Also, this fixes a compilation issue for Sponge that was bugging me, in that the
@Pluginannotation was moved fromorg.spongepowered.plugin.jvm.Plugintoorg.spongepowered.plugin.builtin.jvm.Plugin. Hope you don't mind that change being in this PR.