some new placeholders and fix

[aBooDyy]

Added:
%player_colored_ping% with changeable colors from papi config (Requested by Adam)
%player_biome% (Requested by Adam)
%player_item_in_offhand_level_% cuz why not

Fixes #14
and hopefully made the code a little bit cleaner
https://aboodyy.net/PAPI-Expansion-Player.jar

[aBooDyy]

hmmm? https://img.aboodyy.net/19.04.26_01-52.png
i didnt change all of that ;p

[Andre601]

There are some things that can cause errors when the jar is used.

[aBooDyy]

Thanks for your review, all should be good now

[Andre601]

Seems good to me.
Any additional stuff @extendedclip @Funny-cube @darbyjack ?

[Funny-cube]

Happy to merge, assuming testing has been carried out to ensure new/old placeholders work?

[Andre601]

I myself couldn't test it since I don't have time to compile and check it.

[aBooDyy]

ofc i have tested it,
d95eaaf tested in 1.12.2 and 1.8.8 (i dont remember if i did in 1.13.2)
93c6f1c, 9832152, cd0a9bc, 5f04173, a998778 tested in 1.12.2 only (i think it should work fine in 1.8.8-1.13.2 cuz nothing changed for that in SpigotAPI)
I tested all that placeholders that i have changed them in the code, didnt test other older placeholders since i didnt change anything for them. Tell me if u want me to test them.

i sent a link to download a complied jar for it if anyone want to double check in my first message.
@Funny-cube i didnt changed the version, do u want me to (if so it will be v1.6.5?) if u want to push an update to the cloud? or ull do that?

[Funny-cube]

Ah yeah, you'll need to change the version.

[aBooDyy]

Thank you clip 😁
ill open another PR for the version @Funny-cube