Update Sound-Expansion#2
Open
Andre601 wants to merge 2 commits into
Open
Conversation
Author
Put what into a variable? |
iGabyTM
reviewed
Aug 4, 2021
Member
iGabyTM
left a comment
iGabyTM
left a comment
There was a problem hiding this comment.
Put that Patter#quote into a variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a bunch of improvements from which one is the move to a proper Maven project...
.settings,.ideaandbinfolder alongsidePlaceholderAPI-Expansion-Sound.iml(Why are they even included?)Note that I set target and source to Java 11. This should be fine for most if not all servers and if not can I lower it to 8 when needed.
My basic testing has not shown any issues so far, but I would appreciate if you too could compile and test the expansion to see if it may have some OS dependant issues or something...