Update codebase#19
Closed
BeakerThe1st wants to merge 31 commits into
Closed
Conversation
Contributor
|
The WG Wrapper guarantees support for pre-7 versions. |
Author
Ah, I thought it had something to do with backwards compatibility. However, WorldGuard's documentation mentions "without breaking a significant amount of backwards compatibility" so while I haven't tested it yet, fingers crossed that it is version independent 🤞 |
If all selected regions are children w/ the same priority, spam between them.
iGabyTM
requested changes
Oct 4, 2021
Comment on lines
+247
to
260
| private String getGroupsFromDomain(DefaultDomain domain) { | ||
| StringBuilder stringBuilder = new StringBuilder(); | ||
| Iterator<String> groupsIterator = domain.getGroups().iterator(); | ||
|
|
||
| while (groupsIterator.hasNext()) { | ||
| stringBuilder.append("*"); | ||
| stringBuilder.append(groupsIterator.next()); | ||
| if (groupsIterator.hasNext()) { | ||
| stringBuilder.append(", "); | ||
| } | ||
| } | ||
|
|
||
| return stringBuilder.toString(); | ||
| } |
iGabyTM
requested changes
Oct 4, 2021
| if (highestRegions.size() == 1) { | ||
| return highestRegions.get(0); | ||
| } else if (highestRegions.size() > 1) { | ||
| Random rand = new Random(); |
Member
There was a problem hiding this comment.
Keep an instance at the top of the class instead of creating a new one every time this method is used.
Member
|
Hey @BeakerThe1st are you going to finish this? 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a simple update to the codebase 👍
This PR also moves from the wrapper being used to the native WorldGuard API. Not sure if there's a reason that the wrapper is being used, but this seems much better :)