Skip to content

Solved "NoSuchMethodError", arising from WorldEdit#3

Merged
darbyjack merged 5 commits into
PlaceholderAPI:masterfrom
akaregi:master
Dec 6, 2018
Merged

Solved "NoSuchMethodError", arising from WorldEdit#3
darbyjack merged 5 commits into
PlaceholderAPI:masterfrom
akaregi:master

Conversation

@akaregi
Copy link
Copy Markdown
Contributor

@akaregi akaregi commented Dec 6, 2018

I've fixed an error discussing on issue #2 . This PR solves NoSuchMethodError arising from WorldEdit, due to changing its implementation for Vector3.

And I tested this in my local server. It seems work very well.

Below is a list for changing point by this PR:

  • Version. 1.2.0 => 1.3.0
  • Name. Expansion-WorldGuard => WorldGuard-Expansion
  • The code.

Regards,
akaregi

@akaregi
Copy link
Copy Markdown
Contributor Author

akaregi commented Dec 6, 2018

If you want to test this, you can download this PR's build at my forked repository!
https://github.com/akaregi/WorldGuard-Expansion/releases/tag/pre-2

@Nikokku
Copy link
Copy Markdown

Nikokku commented Dec 6, 2018

I tried this on my main server and can confirm that it works great!

@darbyjack darbyjack merged commit ca90012 into PlaceholderAPI:master Dec 6, 2018
@darbyjack
Copy link
Copy Markdown
Member

Thanks. Will add it in shortly!

@extendedclip
Copy link
Copy Markdown
Member

Ty @akaregi. One concern is this does make the expansion compatible with newer versions of WG / WE but does this new method break backwards compatibility? If so I think we should use some abstraction and version checking to provide compatibility with older and current world guard versions. What you think?

@darbyjack
Copy link
Copy Markdown
Member

There's a repo we can use called a World guard wrapper if we need to.

@akaregi
Copy link
Copy Markdown
Contributor Author

akaregi commented Dec 7, 2018

@extendedclip
Propably no. It seems that WorldEdit only leaves new Vector3 function and doesn't support backwards compatibility. Also, WorldGuard depend on new things of WE. It means we have to use the wrapper or something to support former function.

But I have no idea how to do this, so now I won't support backwards compatibilty(i.e. WE with old "Vector" function). Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants