Fix cancel button on "forgot password" popup#317
Merged
matthijskooijman merged 1 commit intomasterfrom Aug 10, 2020
Merged
Conversation
laurensmartina
approved these changes
Aug 10, 2020
This used to call `showLogin()` to show the login popup (since you typically get to this popup from the login popup). However, the login popup is shown using `login()`, rather than `showLogin()`. This was already broken in the first git commit, so this probably never worked, or got broken in a refactor way before that. This fixes #305.
matthijskooijman
force-pushed
the
fix-forgot-password-cancel
branch
from
979a79c to
8578c2b
Compare
Contributor
Author
|
Rebased on top of master, merging next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This used to call
showLogin()to show the login popup (since youtypically get to this popup from the login popup). However, the login
popup is shown using
login(), rather thanshowLogin().This was already broken in the first git commit, so this probably never
worked, or got broken in a refactor way before that.
This fixes #305.