fix: make ExpertDetails summary fields optional to handle LLM output variability#156
Merged
neoneye merged 1 commit intoPlanExeOrg:mainfrom Mar 7, 2026
Conversation
82deutschmark
added a commit
to VoynichLabs/PlanExe2026
that referenced
this pull request
Mar 7, 2026
feedback_root_cause is the last field in NegativeFeedbackItem. Local LLMs consistently omit trailing required fields in nested JSON list items, causing 3 validation errors for ExpertConsultation in ExpertReviewTask. Confirmed failure: ExpertReviewTask failed 2026-03-06 22:57 EST on Mac Mini M4 Pro 64GB with Qwen 3.5-35B-A3B (num_output=8192). Same truncation pattern as SelectScenarioTask (PlanExeOrg#153) and PreProjectAssessmentTask (PlanExeOrg#155, PlanExeOrg#156).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExpertDetails class in pre_project_assessment.py had two required fields that LLM output sometimes doesn't include. Changed combined_summary and go_no_go_recommendation to Optional[str] with default empty strings to allow graceful handling when LLM omits these fields.