Fix report fallback chain broken by broad try/except#173
Merged
Conversation
…t_from_worker_plan The report path wrapped HTTP + DB + zip fallbacks in a single try/except, so a worker connection error (ConnectError, TimeoutException) returned None and skipped the DB and zip snapshot fallbacks entirely. Extract the report path into _fetch_report_with_fallbacks() with three isolated try/except blocks—one per fallback step—so each failure logs and falls through. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plan_file_infowithartifact=reportreturned empty on production becausefetch_artifact_from_worker_planwrapped HTTP + DB + zip fallbacks in a singletry/except Exception— a worker connection error skipped the DB and zip snapshot fallbacks entirely_fetch_report_with_fallbacks()with three isolatedtry/exceptblocks so each failure logs at warning level and falls through to the next stepTest plan
pytest mcp_cloud/tests/test_worker_fetchers.py— 5 new tests passpytest mcp_cloud/tests/test_plan_file_info_tool.py— 14 existing tests still passplan_file_info(artifact="report")returns report when worker is unreachable but DB/zip has data🤖 Generated with Claude Code