Ath dev#2
Merged
Merged
Conversation
neoneye
approved these changes
Feb 12, 2025
82deutschmark
referenced
this pull request
in 82deutschmark/PlanExe
Sep 29, 2025
CRITICAL BUG FIX #2: Fixed incorrect enum value mapping that caused persistent "Invalid value for SPEED_VS_DETAIL: balanced" errors. Root Cause: - Lines 142-150 of pipeline_execution_service.py had wrong mapping - Used "balanced" and "detailed" which don't exist in Luigi's SpeedVsDetailEnum - Luigi only accepts: "all_details_but_slow" or "fast_but_skip_details" Fix: - Corrected mapping to use Luigi's actual enum values (Source of Truth: planexe/plan/speedvsdetail.py) - "all_details_but_slow" → "all_details_but_slow" ✅ - "balanced_speed_and_detail" → "all_details_but_slow" ✅ (per models.py line 25 comment) - "fast_but_skip_details" → "fast_but_skip_details" ✅ - Updated default fallback to "all_details_but_slow" Impact: - Luigi was rejecting environment variable and logging errors - Pipeline would continue but with wrong speed/detail setting - Now passes valid enum values that Luigi recognizes Testing: - Verified mapping matches Luigi's SpeedVsDetailEnum - Default fallback changed from invalid "balanced" to valid "all_details_but_slow" 🤖 Generated with Claude Code (https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced May 21, 2026
huangyingting
pushed a commit
to repomesh/PlanExe
that referenced
this pull request
May 22, 2026
…hip-set Updates two docs to reflect the post-PlanExeOrg#753 state of the napkin-math pipeline. methology.md: describe the current pipeline behaviour — two-batch compress with paraphrase-tolerant quote match and cross-bucket promoter; extract's source-arithmetic preservation, threshold-pairing, and dropped_signals field; 19-check validator (added aggregate_not_bounded, requirement_has_margin, dropped_signals_schema); bounds' asymmetric source label on commitment defaults, calculation-output strip, reserved correlations block, reserved lognormal/pert disciplines with loud NotImplementedError; advisory audit_source_preservation.py step. 20260520_plan.md → 20260522_plan.md: bump status date; mark PR PlanExeOrg#750 merged; add PR PlanExeOrg#751/PlanExeOrg#752/PlanExeOrg#753 entries (proposal 141 implementation); update Phase status table (added 4.5 audit row, reclassified Phase 8 as partially done, Phase 10 marked done for current ship-set); add v58 14-plan empirical snapshot (1 viable / 5 fragile / 8 doom); reorder Next likely move now that proposal 141 has shipped — Phase 5 citation verifier promoted to PlanExeOrg#1, Phase 8 samplers added as PlanExeOrg#2 with v58 cases that bite now, Phase 9 composite-band cap as PlanExeOrg#3. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
additions: report generator draft
issue: audioop-lts==0.2.1 doesn't install on my machine
configs: oops
feel free to pick and choose from this pull request. I would've made it neater but I haven't made a pull request in a while and I didn't know exactly what I was doing when I started coding.