Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add the plan_feedback tool allowing MCP clients to submit structured feedback about plan quality, workflow friction, and the MCP interface. - New FeedbackItem model (feedback_item table) with inline plan state snapshot - 12 feedback categories (sse_issue, plan_quality, suggestion, etc.) - Fire-and-forget: always returns success even if DB write fails - PLAN_NOT_FOUND error when plan_id is provided but invalid - FastMCP HTTP wrapper and tool registration - Tests for validation, fire-and-forget, plan snapshot capture - Updated surface consistency tests and server instructions Implements proposal 127-mcp-feedback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plan_feedbackMCP tool from proposal docs: add proposal for MCP feedback tool #400 (127-mcp-feedback)Changes
database_api/model_feedback.py—FeedbackItemSQLAlchemy model (feedback_itemtable)mcp_cloud/tests/test_plan_feedback_tool.py— 11 test cases covering validation, fire-and-forget, plan snapshotmcp_cloud/tool_models.py—PlanFeedbackInput/PlanFeedbackOutputPydantic models with 12 categoriesmcp_cloud/schemas.py—ToolDefinitionentry forplan_feedbackmcp_cloud/handlers.py—handle_plan_feedback()handler with plan state snapshottingmcp_cloud/db_queries.py—_create_feedback_sync()and_get_plan_snapshot_for_feedback_sync()mcp_cloud/db_setup.py— model import,PlanFeedbackRequest, server instructions updatemcp_cloud/http_server.py— FastMCP wrapper function and tool registrationmcp_cloud/app.py— re-export facade updatedmcp_cloud/tests/test_tool_surface_consistency.py— annotations, schema, and exposure testsTest plan
test_plan_feedback_tool.py— 11 tests: valid feedback, all categories, validation errors, plan-not-found, fire-and-forget DB failure, plan snapshot capturetest_tool_surface_consistency.py— updated to verify plan_feedback annotations, schema, and server instructionsplan_feedbackvia MCP Inspector with various categories🤖 Generated with Claude Code